Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding validation that checks if AMAZEEIO and LAGOON_LOCALDEV_HTTP_PO… #25

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

adiprinzio93
Copy link

Added empty function for checking if AMAZEEIO and LAGOON_LOCALDEV_HTTP_PORT are not empy

@bomoko
Copy link

bomoko commented Jan 29, 2024

Can confirm this works when run locally.

To test, I set up a standard node app with both a node and cli container. The latter is built using uselagoon/node-18-cli:latest which inherits from the standard node image (which exports LAGOON_LOCALDEV_HTTP_PORT=3000).

I then added a ENV LAGOON_LOCALDEV_HTTP_PORT="" to the cli dockerfile.

Running with the latest pygmy, without this change, I see the following:

image

With the change, I see:

image

The change makes sense. I'm not sure what other checks, if any, we'd like to make on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants