Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace load-generator with Go implementation #748

Merged
merged 4 commits into from
Sep 21, 2024
Merged

Replace load-generator with Go implementation #748

merged 4 commits into from
Sep 21, 2024

Conversation

bboreham
Copy link
Member

@bboreham bboreham commented Sep 20, 2024

This is #743 with one more commit to avoid crashing on empty duration string - instant queries typically have empty start and end times.

Also use Prometheus model.ParseDuration to give more flexibility.

And revert the change to 6_loadgen.yaml, which is in #723.

kakkoyun and others added 3 commits September 3, 2024 14:22
Co-authored-by: Ben Kochie <[email protected]>
Signed-off-by: Harshit Nagpal <[email protected]>
Instant queries typically have empty start and end times.

Also use Prometheus ParseDuration to give more flexibility.

Signed-off-by: Bryan Boreham <[email protected]>
Signed-off-by: Bryan Boreham <[email protected]>
Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bboreham bboreham merged commit 1652c7d into master Sep 21, 2024
4 checks passed
@bboreham bboreham deleted the pull-743 branch September 21, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants