Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add schleifenbauer PDU #1217

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add schleifenbauer PDU #1217

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f52dba0
Add schleifenbauer PDU
Wqrld Jul 17, 2024
339e982
Add schleifenbauer generator.yml and Mib downloads
Wqrld Jul 17, 2024
9a6b2cc
Change schleifenbauer mib url to the tester 244 version
Wqrld Jul 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion generator/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ INFRAPOWER_URL := https://www.austin-hughes.com/wp-content/uploads/2021/05/IP
LIEBERT_URL := https://www.vertiv.com/globalassets/documents/software/monitoring/lgpmib-win_rev16_299461_0.zip
READYNAS_URL := https://www.downloads.netgear.com/files/ReadyNAS/READYNAS-MIB.txt
READYDATAOS_URL := https://www.circitor.fr/Mibs/Mib/R/READYDATAOS-MIB.mib
SCHLEIFENBAUER_URL := https://docs.schleifenbauer.eu/Interfaces/SNMP/PDU_mib_244.zip

CYBERPOWER_VERSION := 2.11
CYBERPOWER_URL := https://dl4jz3rbrsfum.cloudfront.net/software/CyberPower_MIB_v$(CYBERPOWER_VERSION).MIB.zip
Expand Down Expand Up @@ -149,7 +150,10 @@ mibs: \
$(MIBDIR)/LIEBERT_GP_PDU.MIB \
$(MIBDIR)/CyberPower.MIB \
$(MIBDIR)/EAP.MIB \
$(MIBDIR)/EAP-Client.MIB
$(MIBDIR)/EAP-Client.MIB \
$(MIBDIR)/SCHLEIFENBAUER-PRODUCTS-MIB.txt \
$(MIBDIR)/SCHLEIFENBAUER-DATABUS-MIB.txt \
$(MIBDIR)/SCHLEIFENBAUER-SMI.txt

$(MIBDIR)/apc-powernet-mib:
@echo ">> Downloading apc-powernet-mib"
Expand Down Expand Up @@ -367,3 +371,10 @@ $(MIBDIR)/readynas:
$(MIBDIR)/readydataos:
@echo ">> Downloading readydataos"
@curl $(CURL_OPTS) -o $(MIBDIR)/readydataos "$(READYDATAOS_URL)"

$(MIBDIR)/SCHLEIFENBAUER-PRODUCTS-MIB.txt $(MIBDIR)/SCHLEIFENBAUER-DATABUS-MIB.txt $(MIBDIR)/SCHLEIFENBAUER-SMI.txt:
$(eval TMP := $(shell mktemp))
@echo ">> Downloading schleifenbauer to $(TMP)"
@curl $(CURL_OPTS) -o $(TMP) $(SCHLEIFENBAUER_URL)
@unzip -j -d $(MIBDIR) $(TMP) SCHLEIFENBAUER-PRODUCTS-MIB.txt SCHLEIFENBAUER-DATABUS-MIB.txt SCHLEIFENBAUER-SMI.txt
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SCHLEIFENBAUER-PRODUCTS-MIB.txt seems not to be included in this zipfile, only in the older https://docs.schleifenbauer.eu/Interfaces/SNMP/PDU_mib_244.zip. If the file is necessary we'd need to get it from the 2nd zipfile.

@rm -v $(TMP)
8 changes: 8 additions & 0 deletions generator/generator.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -628,3 +628,11 @@ modules:
hrSWInstalled:
walk:
- hrSWInstalled

#
# Schleifenbauer
#
# https://docs.schleifenbauer.eu/?dir=Interfaces/SNMP
schleifenbauer:
walk:
- 1.3.6.1.4.1.31034.12
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This OID is overly broad. I think we want to be more targeted here with which walks to include. Some of the metrics included by this are read-write settings OIDs that have no meaning as metrics.

Let's start with the most useful part, the device table.

Suggested change
- 1.3.6.1.4.1.31034.12
- sdbMgmtCtrlDevicesTable

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think almost everything in 1.3.6.1.4.1.31034.12.1.1.2 would be of use, which is basically the whole generated list. There are a few you could leave out, but for my usecase more is better.

Loading