Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collector/cpu_netbsd: fix 32-bit host support and plug memory leak #3083

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tnn2
Copy link
Contributor

@tnn2 tnn2 commented Aug 4, 2024

  • Correct plistref stucture. The correct size of the plistref structure must be used in ioctl number computation.
  • Replace hardcoded ioctl number computation to match what the ioctl macros do in C.
  • plist memory returned from ENVSYS_GETDICTIONARY must be unmapped after we're done.

cc @MatthiasPetermann Does this look ok to you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant