Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Fix links to java client documentation #2521

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: Fix links to java client documentation #2521

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions content/docs/concepts/metric_types.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ use a counter for the number of currently running processes; instead use a gauge
Client library usage documentation for counters:

* [Go](http://godoc.org/github.com/prometheus/client_golang/prometheus#Counter)
* [Java](https://github.com/prometheus/client_java#counter)
* [Java](https://prometheus.github.io/client_java/getting-started/metric-types/#counter)
* [Python](https://prometheus.github.io/client_python/instrumenting/counter/)
* [Ruby](https://github.com/prometheus/client_ruby#counter)
* [.Net](https://github.com/prometheus-net/prometheus-net#counters)
Expand All @@ -42,7 +42,7 @@ concurrent requests.
Client library usage documentation for gauges:

* [Go](http://godoc.org/github.com/prometheus/client_golang/prometheus#Gauge)
* [Java](https://github.com/prometheus/client_java#gauge)
* [Java](https://prometheus.github.io/client_java/getting-started/metric-types/#gauge)
* [Python](https://prometheus.github.io/client_python/instrumenting/gauge/)
* [Ruby](https://github.com/prometheus/client_ruby#gauge)
* [.Net](https://github.com/prometheus-net/prometheus-net#gauges)
Expand Down Expand Up @@ -80,7 +80,7 @@ to becoming a stable feature.
Client library usage documentation for histograms:

* [Go](http://godoc.org/github.com/prometheus/client_golang/prometheus#Histogram)
* [Java](https://github.com/prometheus/client_java#histogram)
* [Java](https://prometheus.github.io/client_java/getting-started/metric-types/#histogram)
* [Python](https://prometheus.github.io/client_python/instrumenting/histogram/)
* [Ruby](https://github.com/prometheus/client_ruby#histogram)
* [.Net](https://github.com/prometheus-net/prometheus-net#histogram)
Expand All @@ -106,7 +106,7 @@ to [histograms](#histogram).
Client library usage documentation for summaries:

* [Go](http://godoc.org/github.com/prometheus/client_golang/prometheus#Summary)
* [Java](https://github.com/prometheus/client_java#summary)
* [Java](https://prometheus.github.io/client_java/getting-started/metric-types/#summary)
* [Python](https://prometheus.github.io/client_python/instrumenting/summary/)
* [Ruby](https://github.com/prometheus/client_ruby#summary)
* [.Net](https://github.com/prometheus-net/prometheus-net#summary)
2 changes: 1 addition & 1 deletion content/docs/introduction/faq.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ either standalone or as a Java Agent.
### What is the performance impact of instrumentation?

Performance across client libraries and languages may vary. For Java,
[benchmarks](https://github.com/prometheus/client_java/blob/master/benchmarks/README.md)
[benchmarks](https://github.com/prometheus/client_java/blob/main/benchmarks/README.md)
indicate that incrementing a counter/gauge with the Java client will take
12-17ns, depending on contention. This is negligible for all but the most
latency-critical code.
Expand Down
2 changes: 1 addition & 1 deletion content/docs/practices/instrumentation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@ inside a given process, you may wish to take some care as to how many metrics
you update.

A Java counter takes
[12-17ns](https://github.com/prometheus/client_java/blob/master/benchmark/README.md)
[12-17ns](https://github.com/prometheus/client_java/blob/main/benchmarks/README.md)
to increment depending on contention. Other languages will have similar
performance. If that amount of time is significant for your inner loop, limit
the number of metrics you increment in the inner loop and avoid labels (or
Expand Down