Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Gameplay stubs (Sliderbreak, Tablet cover, Fingerlock, Mind block) #3868

Merged
merged 11 commits into from
Oct 3, 2020
Merged

Create Gameplay stubs (Sliderbreak, Tablet cover, Fingerlock, Mind block) #3868

merged 11 commits into from
Oct 3, 2020

Conversation

MilkyIQ
Copy link
Contributor

@MilkyIQ MilkyIQ commented Jul 11, 2020 •
edited
Loading

Creates stubs for the following terms:

  • Sliderbreak
  • Tablet cover
  • Fingerlock
  • Mind block

Part of organization effort #3143.

8/15 - how did i not have an aneurysm writing this?

@Loctav Loctav mentioned this pull request Jul 12, 2020
Closed
35 tasks
@MegaApplePi MegaApplePi self-requested a review August 11, 2020 04:59
MegaApplePi
MegaApplePi requested changes Aug 12, 2020
View reviewed changes
Copy link
Contributor

@MegaApplePi MegaApplePi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding the Fingerlock article, it looks like there are some spelling mistakes in it. I'll take a look at this PR as soon as I can later.

wiki/Gameplay/Fingerlock/en.md Outdated Show resolved Hide resolved
@MegaApplePi MegaApplePi self-assigned this Sep 12, 2020
@Joehuu Joehuu self-requested a review September 24, 2020 07:39
Joehuu
Joehuu reviewed Sep 24, 2020
View reviewed changes
Copy link
Member

@Joehuu Joehuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after this.

Also not really sure about the consensus of adding a space or not on the default format of these gameplay terms.

wiki/Gameplay/Fingerlock/en.md Outdated Show resolved Hide resolved
wiki/Gameplay/Mind_block/en.md Show resolved Hide resolved
@MegaApplePi @Joehuu
Make header consistent
c333d87 
Co-authored-by: Joseph Madamba <[email protected]>
@MegaApplePi MegaApplePi merged commit 8cabf5b into ppy:master Oct 3, 2020
@MilkyIQ MilkyIQ deleted the stubs-gameplay3 branch December 2, 2020 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Joehuu Joehuu Joehuu left review comments

@MegaApplePi MegaApplePi MegaApplePi approved these changes

Assignees

@MegaApplePi MegaApplePi

Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MilkyIQ @MegaApplePi @Joehuu