Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a special lazer wiki for all lazer mods (preview) #12105

Open
wants to merge 71 commits into
base: master
Choose a base branch
from

Conversation

Anax2i
Copy link

@Anax2i Anax2i commented Sep 6, 2024

Copy link

github-actions bot commented Sep 6, 2024

Thank you for contributing to the osu! wiki.

Please take note of the following:

  • Make sure you've read this self-check checklist.

  • Translations that have not been reviewed by a native speaker will be merged after a minimum of 1 week. If there are no reviewers for your language, please mention it explicitly.

  • Refrain from spamming the Update branch button. A maintainer will do this before merging anyway.

  • Apply review suggestions in batches from the Files changed tab like this:

    Demo GIF

See the contribution guide for more information.

All changes are run through continuous integration checks, which provide automatic detection of common errors. If you need help with decrypting CI check error messages, or with any other issues, ask in the #osu-wiki channel on the osu! Discord server.

Copy link
Member

@Hiviexd Hiviexd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

things i noticed on a first glance:

  • should replace lazer with osu!(lazer) whenever possible
  • would be better to put mod icon images in infoboxes rather than inline
  • should probably point out the settings of each mod in a header and explain each of them a bit

@cl8n cl8n self-requested a review September 6, 2024 23:42
wiki/Gameplay/Game_modifier/Lazer/Classic/en.md Outdated Show resolved Hide resolved
wiki/Gameplay/Game_modifier/Easy/en.md Outdated Show resolved Hide resolved
wiki/Gameplay/Game_modifier/Lazer/Classic/en.md Outdated Show resolved Hide resolved
wiki/Gameplay/Game_modifier/Lazer/Easy/en.md Outdated Show resolved Hide resolved
wiki/Gameplay/Game_modifier/Lazer/Floating_Fruits/en.md Outdated Show resolved Hide resolved
wiki/Gameplay/Game_modifier/Lazer/No_Scope/en.md Outdated Show resolved Hide resolved
wiki/Gameplay/Game_modifier/en.md Outdated Show resolved Hide resolved
wiki/Gameplay/Game_modifier/Lazer/Classic/en.md Outdated Show resolved Hide resolved
wiki/Gameplay/Game_modifier/Lazer/Easy/en.md Outdated Show resolved Hide resolved
wiki/Gameplay/Game_modifier/Lazer/en.md Outdated Show resolved Hide resolved
@cl8n
Copy link
Member

cl8n commented Sep 7, 2024

  • should replace lazer with osu!(lazer) whenever possible

I think this isn't great writing advice, there is a place for osu!(lazer) when you need to clarify the version you're talking about, but if you are specifically comparing against stable then just "lazer" reads a lot better. this article has examples of both ways to write it that are used well imo

wiki/Gameplay/Game_modifier/Easy/en.md Outdated Show resolved Hide resolved
wiki/Gameplay/Game_modifier/Lazer/Easy/en.md Outdated Show resolved Hide resolved
wiki/Gameplay/Game_modifier/Lazer/img/mods/README.md Outdated Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thoughts on preemptively putting these images into wiki/shared/mods/lazer/?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i dont think they'll be used outside of these articles because they're too big to casually fit anywhere else

@Joehuu Joehuu self-requested a review October 10, 2024 04:25
wiki/Gameplay/Game_modifier_(lazer)/en.md Outdated Show resolved Hide resolved
wiki/Gameplay/Game_modifier/Grow/en.md Outdated Show resolved Hide resolved
wiki/Gameplay/Game_modifier/Deflate/en.md Outdated Show resolved Hide resolved
wiki/Gameplay/Game_modifier/Classic/en.md Outdated Show resolved Hide resolved
Copy link
Member

@cl8n cl8n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to be clear about the status of this PR, still looking for

  • better intro for game modifier page (should explain what a mod is, i.e. the topic of the article, before going into other details)
  • writing about each mod explaining its effect
  • section about each mods' settings, where applicable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L state/needs rebase before merging, a maintainer will rebase to fix commit messages, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants