Add note about why we're providing a custom signTemplate

ppy · Sep 26, 2024 · 6e605d7 · 6e605d7
1 parent c3573f9
commit 6e605d7
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/Builders/WindowsBuilder.cs b/Builders/WindowsBuilder.cs
@@ -39,6 +39,10 @@ public override Uploader CreateUploader()
                 if (dllPath == null)
                     Logger.Error("Could not find path for Dlib.dll");
 
+                // We're using `signTemplate` here as we need to prefer the system `signtool.exe` in order for it to
+                // run azure code signing correctly on older windows versions.
+                //
+                // This can be changed back to `signParams` if velopack changes the signtool logic to fix this.
                 string signToolPath = Directory.GetDirectories(@"C:\Program Files (x86)\Windows Kits\10\bin", "*", SearchOption.AllDirectories)
                                                .Select(dir => Path.Combine(dir, @"x64\signtool.exe"))
                                                .Where(File.Exists)