add deprecation notice for mapbox traces #4783
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gvwilson
approved these changes
Oct 8, 2024
|
These show up when you are using the new traces 
Also, it looks like they are removed when we run the commands to update Plotly.js. Those classes are probably autogenerated |
|
cc @archmoj |
ndrezn
reviewed
Oct 8, 2024
| print( | ||
| "*choroplethmapbox* trace is deprecated!", | ||
| "Please consider switching to the *choroplethmap* trace type and `map` subplots.", | ||
| "Learn more at: https://plotly.com/javascript/maplibre-migration/", |
There was a problem hiding this comment.
All links should point to the Python documentation: https://plotly.com/python/mapbox-to-maplibre/
ndrezn
reviewed
Oct 8, 2024
| @@ -3,6 +3,11 @@ | |||
|
|
|||
|
|
|||
| class Choroplethmapbox(_BaseTraceType): | |||
| print( | |||
There was a problem hiding this comment.
We should use a proper warning rather than print statements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4730.