Bump jquery to 1.12.4
#236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffwidman
force-pushed
the
use-jquery-migrate-1.4.1
branch
from
c9c1621
to
a025cd7
Compare
jeffwidman
changed the title
jquery to 1.12.4
jeffwidman
force-pushed
the
update-jquery-table-sorter
branch
from
f29a97a
to
72a56f2
Compare
jeffwidman
force-pushed
the
update-jquery-table-sorter
branch
from
72a56f2
to
18a78df
Compare
greyli
approved these changes
Apr 13, 2024
This will allow us to migrate to the latest version of jquery 1.x series. After we're on 1.9.x we can upgrade to the 3.x series. This PR may not need to be merged, but only the fixes discovered in the console warnings... not sure.
I bumped this, and then checked the developer console while clicking through the various panels offered in FDBT... Everything worked as expected and I got zero warnings from `jquery-migrate`. So I think it's safe to pull this in. This is a pre-requesite to upgrading to the latest version of `jquery`, as per their docs we have to first bump to `1.9+`, then bump the version of `jquery-migrate`, then can bump to latest `jquery` version. While I could do this in a single PR, I thought simpler to do it as a series of PRs for easier reversion if we later run into problems.
jeffwidman
force-pushed
the
use-jquery-migrate-1.4.1
branch
from
a2c914d
to
791b7fa
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow us to migrate to the latest version of jquery 1.x series.
After we're on 1.9.x we can upgrade to the 3.x series.
I bumped this, and then checked the developer console while clicking
through the various panels offered in FDBT... Everything worked as
expected and I got zero warnings from
jquery-migrate. So I think it'ssafe to pull this in.
This is a pre-requesite to upgrading to the latest version of
jquery,as per their docs we have to first bump to
1.9+, then bump the versionof
jquery-migrate, then can bump to latestjqueryversion.While I could do this in a single PR, I thought simpler to do it as a
series of PRs for easier reversion if we later run into problems.
Related: