Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tox and GitHub actions settings #217

Merged
merged 2 commits into from
Nov 16, 2023
Merged

Conversation

greyli
Copy link
Member

@greyli greyli commented Nov 16, 2023

Copy link
Contributor

@nickjj nickjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about using single quotes around the name for all 3 Python 3.12 names? This would match the others.

@@ -7,8 +7,6 @@ on:
- 'docs/**'
- '*.rst'
pull_request:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I double checked this in the docs at: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet

When you omit any value here it defaults to '**' which matches all branch and tag names.

@greyli
Copy link
Member Author

greyli commented Nov 16, 2023

What do you think about using single quotes around the name for all 3 Python 3.12 names? This would match the others.

It's OK since these names don't contain dots or whitespaces. Similar to the settings in Flask.

Copy link
Contributor

@macnewbold macnewbold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good to me.

.github/workflows/tests.yml Outdated Show resolved Hide resolved
@jeffwidman
Copy link
Member

Let's ship this, added a trivial inline code comment for clarity, hope you don't mind. If you do feel strongly about that, let me know so that in the future I know to wait for you.

@jeffwidman jeffwidman merged commit f959951 into pallets-eco:master Nov 16, 2023
0 of 10 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants