Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rhel-ha-aws-check.sh in CIV #338

Merged
merged 2 commits into from
Sep 22, 2024
Merged

Update rhel-ha-aws-check.sh in CIV #338

merged 2 commits into from
Sep 22, 2024

Conversation

sshmulev
Copy link
Collaborator

@sshmulev sshmulev requested a review from narmaku August 27, 2024 11:20
@narmaku
Copy link
Collaborator

narmaku commented Aug 28, 2024

Comparing the full raw file against the one in main here, it is slightly different:

narmaku
narmaku requested changes Aug 28, 2024
View reviewed changes
Copy link
Collaborator

@narmaku narmaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the original script content to fully replace ours.

scripts/aws/rhel-ha-aws-check.sh Outdated Show resolved Hide resolved
narmaku
narmaku approved these changes Aug 28, 2024
View reviewed changes
Copy link
Collaborator

@narmaku narmaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sshmulev sshmulev enabled auto-merge (rebase) August 28, 2024 08:32
@sshmulev sshmulev disabled auto-merge August 28, 2024 09:34
@narmaku narmaku force-pushed the refactotr_rhel_ha_aws_check_sh branch from 1ee45e0 to cadcf83 Compare September 20, 2024 07:56
@narmaku narmaku enabled auto-merge (rebase) September 20, 2024 07:56
@sshmulev sshmulev force-pushed the refactotr_rhel_ha_aws_check_sh branch from cadcf83 to 06c7083 Compare September 22, 2024 07:05
@sshmulev sshmulev force-pushed the refactotr_rhel_ha_aws_check_sh branch from 06c7083 to b540df7 Compare September 22, 2024 09:15
@narmaku narmaku merged commit bd874c3 into main Sep 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narmaku narmaku narmaku approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sshmulev @narmaku