[qa] Add pre-push hook #161 #162

purhan · 2020-11-30T05:09:32Z

Closes #161

purhan · 2020-11-30T05:13:31Z

@atb00ker This is functional in the current state, but I would like to add a couple more features:

It should be installed automatically (this is a subjective opinion)
It requires some tests.

What do you think?

atb00ker · 2020-11-30T15:54:19Z

It should be installed automatically (this is a subjective opinion)

Can this file be directly added to hooks folder? Do we need to install it for some reason?

Two more things:

if script fails because setup for testing is not done, then we should inform the user. 😄
Can this file be moved to some other place like .github if adding it to hooks is not possible? 😄

purhan · 2020-11-30T17:06:06Z

Can this file be directly added to hooks folder? Do we need to install it for some reason?

From what I know, it sits in .git/hooks which is not shared in the working environment. So I'm just creating a symlink into that folder. I looked at other projects who use hooks and this is how some of them did it. Maybe a better solution is there, I will have to do more research.

if script fails because setup for testing is not done, then we should inform the user. 😄

I will try to add this in the next commit

nemesifier

I think we should make this reusable for every openwisp module, having this mechanism only in openwisp-utils is not very useful.

If we could make this more generic it would be a lot more useful, eg:

make it possible to call the script with openwisp-pre-push-hook (similar to openwisp-qa-format and openwisp-qa-check
runtests.py works only for python modules, we also have runtests and npm packages which get tested with yarn test, would be great if the script is able to figure this out (call the file only if exists, check if package.json is present and in that case use yarn test
the push may be done without the python virtualenv being enabled, try importing openwisp_utils and if the import fails print to standard error a message that advises to activate the right virtualenv

What do you think @purhan @atb00ker?

purhan · 2020-12-01T10:10:58Z

@nemesisdesign @atb00ker After the latest commit, openwisp-pre-push-hook can be installed while installing openwisp-utils itself. The hook can then be set up using openwisp-pre-push-hook --install, which can be included in the setup.py script of any module thereafter.
The hook needs to be installed separately as git doesn't allow it for security reasons.

nemesifier

Looks good! I think we need some basic automated tests for this new code to ensure it will keep working over time also when new contributors will try to change it.

See also my comment below.

README.rst

nemesifier · 2020-12-01T15:25:34Z

openwisp-pre-push-hook

+            "'openwisp_utils' failed to import. Make sure all dependencies "
+            "are installed and virtual environment is activated."
+        )
+    checks = ['run-qa-checks', 'runtests.py', 'runtests']


here's some more problems, we need to give this a bit more thought if we want it to really be useful.

For some repositories, running all the tests can take a long time, so we usually run tests using --parallel.
But in openwisp-monitoring we can't use --parallel.

More over, in some repos we also run tests with SAMPLE_APP=1.

Dealing with these cases here would complicate things too much.

I think we could just delegate everything to the run-qa-checks script in every repository: this script would also run tests, eg:

./run-qa-checks runs ./runtests.py --parallel and SAMPLE_APP=1 ./runtests.py --parallel in openwisp-radius

./run-qa-checks runs ./runtests.py and SAMPLE_APP=1 ./runtests.py in openwisp-monitoring

./run-qa-checks runs yarn test in openwisp-wifi-login-pages

But we should allow each ./run-qa-checks script to be called from the CI builds, eg:

./run-qa-checks --ci, so we can skip the --parallel flag in some cases otherwise the test coverage would drop.

@atb00ker @pandafy @nepython @NoumbissiValere @okraits what do you think? Any other useful suggestion? Or alternative approach?

This looks good, @purhan I would suggest before this is merged, open a related PR in another module like controller and use it there for actual testing! 😄

./run-qa-checks --ci, so we can skip the --parallel flag in some cases otherwise the test coverage would drop.

What if we instead, use a flag for the hook (--hook) and everything else works as normal with minimal changes?

devkapilbansal · 2020-12-02T20:09:38Z

@purhan I would suggest to look in this too Pre-Commit. This can make your work a lot easier

purhan · 2020-12-03T11:53:12Z

@purhan I would suggest to look in this too Pre-Commit. This can make your work a lot easier

@devkapilbansal this is a handy project but personally I'm not in favor of using third-party libraries for this, though I would still like to hear what the other devs have to say.

atb00ker · 2020-12-03T15:08:15Z

KISS: Keep it stupid simple.
Libraries are great, but we are doing very small thing here, why add a dependency unless we really need it!? 😄

purhan · 2020-12-03T17:21:06Z

@atb00ker @nemesisdesign Please take another look at the latest commit. I have moved some of the logic to run-qa-checks which can be changed in any module to work with the hook.

nemesifier · 2020-12-03T20:45:39Z

I agree on keeping it simple for now and later on as our understanding and needs grow we can decide to switch to a third party library if we deem it worth it.

coveralls · 2020-12-04T07:40:52Z

Coverage remained the same at 99.757% when pulling d32c30c on Purhan:issues/161-add-pre-push-hook into 30ad216 on openwisp:master.

atb00ker

LGTM!
Just please squash the 4 commits! 😄

Closes openwisp#161

purhan · 2020-12-04T17:44:40Z

@atb00ker Done :)

purhan · 2021-01-02T13:34:31Z

Following up on discussion from openwisp/openwisp-docs#100. Should openwisp-pre-push-hook be renamed and more generalized?

atb00ker · 2021-01-03T09:31:29Z

I thought this one was already merged? 😮
openwisp-pre-push-hook sounds generic to me! 😄
ping: @nemesisdesign

nemesifier

Thanks @atb00ker for pinging me and thanks @purhan for your patience.

Now in order to avoid forgetting about this work and start to use it also in the rest of OpenWISP, what do you suggest would be the next step? Should we add a reference from https://github.com/openwisp/openwisp2-docs?
I guess we already have an issue for that: openwisp/openwisp-docs#100

purhan · 2021-03-09T18:26:33Z

Now in order to avoid forgetting about this work and start to use it also in the rest of OpenWISP, what do you suggest would be the next step? Should we add a reference from https://github.com/openwisp/openwisp2-docs?
I guess we already have an issue for that: openwisp/openwisp2-docs#100

Yes, I think it belongs in the contribution guidelines. This is more or less an optional feature, could be mentioned in the code conventions section

purhan force-pushed the issues/161-add-pre-push-hook branch from ff9c4b2 to 531686f Compare November 30, 2020 06:23

nemesifier reviewed Dec 1, 2020

View reviewed changes

nemesifier requested changes Dec 1, 2020

View reviewed changes

README.rst Outdated Show resolved Hide resolved

nemesifier reviewed Dec 1, 2020

View reviewed changes

purhan force-pushed the issues/161-add-pre-push-hook branch from 3eccd95 to 829c3e0 Compare December 3, 2020 18:16

purhan force-pushed the issues/161-add-pre-push-hook branch from 829c3e0 to cf0ca0e Compare December 4, 2020 07:39

atb00ker approved these changes Dec 4, 2020

View reviewed changes

[qa] Add pre-push hook openwisp#161

d32c30c

Closes openwisp#161

purhan force-pushed the issues/161-add-pre-push-hook branch from cf0ca0e to d32c30c Compare December 4, 2020 17:44

purhan self-assigned this Dec 12, 2020

pandafy requested a review from nemesifier December 28, 2020 08:08

priyanshuone6 mentioned this pull request Jan 2, 2021

[developer] Add and explain pre-commit-hook openwisp/openwisp-docs#100

Open

nemesifier approved these changes Mar 9, 2021

View reviewed changes

nemesifier merged commit 0786b4a into openwisp:master Mar 9, 2021

purhan deleted the issues/161-add-pre-push-hook branch March 9, 2021 18:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[qa] Add pre-push hook #161 #162

[qa] Add pre-push hook #161 #162

purhan commented Nov 30, 2020

purhan commented Nov 30, 2020

atb00ker commented Nov 30, 2020

purhan commented Nov 30, 2020

nemesifier left a comment

purhan commented Dec 1, 2020 •

edited

Loading

nemesifier left a comment

nemesifier Dec 1, 2020 •

edited

Loading

atb00ker Dec 1, 2020

purhan Dec 3, 2020 •

edited

Loading

devkapilbansal commented Dec 2, 2020 •

edited

Loading

purhan commented Dec 3, 2020

atb00ker commented Dec 3, 2020

purhan commented Dec 3, 2020

nemesifier commented Dec 3, 2020

coveralls commented Dec 4, 2020 •

edited

Loading

atb00ker left a comment

purhan commented Dec 4, 2020

purhan commented Jan 2, 2021

atb00ker commented Jan 3, 2021

nemesifier left a comment

purhan commented Mar 9, 2021

[qa] Add pre-push hook #161 #162

[qa] Add pre-push hook #161 #162

Conversation

purhan commented Nov 30, 2020

purhan commented Nov 30, 2020

atb00ker commented Nov 30, 2020

purhan commented Nov 30, 2020

nemesifier left a comment

Choose a reason for hiding this comment

purhan commented Dec 1, 2020 • edited Loading

nemesifier left a comment

Choose a reason for hiding this comment

nemesifier Dec 1, 2020 • edited Loading

Choose a reason for hiding this comment

atb00ker Dec 1, 2020

Choose a reason for hiding this comment

purhan Dec 3, 2020 • edited Loading

Choose a reason for hiding this comment

devkapilbansal commented Dec 2, 2020 • edited Loading

purhan commented Dec 3, 2020

atb00ker commented Dec 3, 2020

purhan commented Dec 3, 2020

nemesifier commented Dec 3, 2020

coveralls commented Dec 4, 2020 • edited Loading

atb00ker left a comment

Choose a reason for hiding this comment

purhan commented Dec 4, 2020

purhan commented Jan 2, 2021

atb00ker commented Jan 3, 2021

nemesifier left a comment

Choose a reason for hiding this comment

purhan commented Mar 9, 2021

purhan commented Dec 1, 2020 •

edited

Loading

nemesifier Dec 1, 2020 •

edited

Loading

purhan Dec 3, 2020 •

edited

Loading

devkapilbansal commented Dec 2, 2020 •

edited

Loading

coveralls commented Dec 4, 2020 •

edited

Loading