Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deps] Fixed openssl dependency in Nginx Image #318 #362

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

pandafy
Copy link
Member

@pandafy pandafy commented Sep 18, 2024

Checklist

  • I have read the OpenWISP Contributing Guidelines.
  • I have manually tested the changes proposed in this pull request.
  • I have written new test cases for new code and/or updated existing tests for changes to existing code.
  • I have updated the documentation.

Description of Changes

In #318, I initially removed the OpenSSL dependency from the Nginx image, assuming it was included in the base image. However, the base image removes the OpenSSL package in a later build step. This commit reinstates the OpenSSL dependency to ensure proper functionality.

Related to #318

@pandafy
Copy link
Member Author

pandafy commented Sep 18, 2024

I investigated why this issue was not caught by the CI and discovered that the openssl command is only triggered when the SSL certificate and key are missing. In our CI process, we first deploy the existing edge version before deploying the image built in the CI. As a result, the certificates were already present in the second deployment, so the openssl command was never executed, allowing the bug to go unnoticed.

In #318, I initially removed the OpenSSL dependency from the Nginx
image, assuming it was included in the base image. However, the base
image removes the OpenSSL package in a later build step.
This commit reinstates the OpenSSL dependency to ensure proper
functionality.

Related #318
@nemesifier nemesifier merged commit 877bb14 into master Sep 18, 2024
2 of 3 checks passed
@nemesifier nemesifier deleted the fix-nginx-image branch September 18, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants