EA-198-2: Add support for configuring (and fetching) Mother Child rel… #238
Conversation
…ationships within the EMR API module
|
Okay, took a while to rename all the classes and variables in the test case, but, mircalously all the tests passed first time after it compiled. I probably need to give this one more once-over before merging, and add a couple tests around the weird cases where you are restricting by both mother and child in a single request. Will take a look tomorrow, but wanted to get this open for review. |
|
|
||
| for (Object req : l) { | ||
| Object[] row = (Object[]) req; | ||
| Child child = new Child(); | ||
| MotherAndChild child = new MotherAndChild(); |
There was a problem hiding this comment.
Probably should rename this local variable to motherAndChild, though you could also just have a constructor that takes in both and not need a local variable at all...
There was a problem hiding this comment.
Whoops, yep... missed this one.
| private List<String> childUuids; // restrict to mothers of these children | ||
| private boolean requireMotherHasActiveVisit = false; // restrict to mothers who have an active visit | ||
| private boolean requireChildHasActiveVisit = false; // restrict to mothers of children who have an active visit | ||
| private boolean requireChildBornDuringMothersActiveVisit = false; // restrict to mothers who had a child born during their active visit |
There was a problem hiding this comment.
If you did want these to read better, you could go with something like:
motherRequiredToHaveActiveVisit -> isMotherRequiredToHaveActiveVisit()
childRequiredToHaveActiveVisit -> isChildRequiredToHaveActiveVisit()
childRequiredToBeBornDuringMothersActiveVisit -> isChildRequiredToBeBornDuringMothersActiveVisit()
…ionships within the EMR API module (update with code review comments)
…ationships within the EMR API module