Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(refactor) O3-3870 Move inline styles to SCSS file #1984

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

(refactor) O3-3870 Move inline styles to SCSS file #1984

wants to merge 1 commit into from

Conversation

WodPachua
Copy link

@WodPachua WodPachua commented Aug 30, 2024 •
edited by denniskigen
Loading

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

Moved inline styles in print-identifier-sticker-content.component.tsx to print-identifier-sticker-content.scss

Screenshots

Related Issue

O3-3870
O3-3521

Other

@WodPachua WodPachua marked this pull request as ready for review August 30, 2024 13:52
@WodPachua WodPachua marked this pull request as draft August 30, 2024 13:53
Vijaykv5
Vijaykv5 reviewed Aug 31, 2024
View reviewed changes
Copy link
Contributor

@Vijaykv5 Vijaykv5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WodPachua Please keep the PR title shorter?

@WodPachua WodPachua changed the title (refactor) O3-3870 Move inline styles in print-identifier-sticker-content.component.tsx to print-identifier-sticker-content.scss (refactor) O3-3870 Move inline styles to SCSS file Aug 31, 2024
@WodPachua
Copy link
Author

@WodPachua Please keep the PR title shorter?

Sure, thanks @Vijaykv5 ... fixed ✌️

@WodPachua
(refactor) Move inline styles in print-identifier-sticker-content.com…
c2fe1ff 
…ponent.tsx to print-identifier-sticker-content.scss
@WodPachua WodPachua marked this pull request as ready for review September 18, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vijaykv5 Vijaykv5 Vijaykv5 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WodPachua @Vijaykv5