(fix) O3-3871 Upgrade react-to-print library to v3 beta to resolve TypeError #1979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnsereko
suggested changes
Aug 29, 2024
There was a problem hiding this comment.
Thank you @WodPachua.
Would also update parameters to useReactToPrint in all its usages within this repo?
Is this the update you had proposed? @jnsereko |
WodPachua
force-pushed
the
fix/upgrade-react-to-print-v3-beta
branch
from
4d4febc
to
8e27da5
Compare
| react: ^15.0.0 || ^16.0.0 || ^17.0.0 || ^18.0.0 | ||
| react-dom: ^15.0.0 || ^16.0.0 || ^17.0.0 || ^18.0.0 | ||
| checksum: 10/cc4e438b5b7e5c67a73ca3d87ff0f1b5a550a7e6c1a1911cded14c9591b286efd82029bd0447e016b0b404f274d546a108e760fd7867e6b73342dba450282a29 | ||
| react: ^16.8.0 || ^17.0.0 || ^18.0.0 || ~19 |
There was a problem hiding this comment.
Isn't this auto-generated to reflect the dependency(react-to-print version) change?
|
Depends on and is blocked by #1934. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Upgraded the react-to-print library to version 3 beta to resolve a TypeError encountered during the first print attempt in the development environment. This issue was not observed in the production environment
Screenshots
Related Issue
O3-3871
Other