Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant function (needs Go >= 1.23) #4387

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

BooleanCat
Copy link

Make use of Go 1.23's news maps and slices iterators to replace a hand-crafted map key sorter.

This relies on Go 1.23 being the minimum version - once it's updaded in go.mod I'll modify this commit to remove my change to go.mod.

Signed-off-by: Tom Godkin <[email protected]>
@BooleanCat
Copy link
Author

I'm guessing you follow the same support policy for Go versions as the language itself? (i.e. this minor and the previous)

@AkihiroSuda
Copy link
Member

I'm guessing you follow the same support policy for Go versions as the language itself? (i.e. this minor and the previous)

Yes, so we still have to support Go 1.22

@BooleanCat
Copy link
Author

@AkihiroSuda understood, I'll leave this open until 1.24 or if you want to close I'll open another when it's released.

@AkihiroSuda AkihiroSuda marked this pull request as draft August 30, 2024 09:51
@AkihiroSuda AkihiroSuda changed the title Remove redundant function Remove redundant function (needs Go >= 1.23) Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants