Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setrelease improvements #16545

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

setrelease improvements #16545

wants to merge 2 commits into from
+75 −65

Conversation

adrianschroeter
Copy link
Member

Allow to set it via api and allow to opt-out default stripping via setrelease=-

@github-actions github-actions bot added Frontend Things related to the OBS RoR app Backend Things regarding the OBS backend labels Jul 23, 2024
hennevogel
hennevogel requested changes Jul 23, 2024
View reviewed changes
Copy link
Member

@hennevogel hennevogel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add API Documentation

@github-actions github-actions bot added the Documentation 📖 Things regarding our documentation label Jul 24, 2024
@adrianschroeter adrianschroeter force-pushed the setrelease branch 4 times, most recently from 4b08c04 to 390b21c Compare July 24, 2024 13:39
@oSoMoN oSoMoN mentioned this pull request Jul 29, 2024
Open
@dirkmueller
Copy link
Member

@hennevogel there's apidocs as far as I can see?

@hennevogel
Copy link
Member

@hennevogel there's apidocs as far as I can see?

Sure thing it got added after my review. I can drop the review but it'll not make the CI go green...

@adrianschroeter
Copy link
Member Author

that are timeout errors that suddenly the source server is not reachable anymore ... these errors don't happen in our package for our production systems where these test cases are running as well (but there are also more fixes for release handling, however I don't see that any of them fix a hanging source server).

@hennevogel
Copy link
Member

that are timeout errors that suddenly the source server is not reachable anymore ...

There is no source server in rspec tests, just recordings of source server answers. See https://github.com/openSUSE/open-build-service/wiki/Testing-with-VCR

If you need help with this, let us know.

these errors don't happen in our package for our production systems

The package for our production systems does not run the specs during build, just the minitest test suite.

@adrianschroeter
[api] allow to hand over setrelease via token trigger
9f7d5f6 
Release command knows the setrelease parameter. Make it
also possible to use it when executing via a token.
@adrianschroeter
[api] cleanup and document release api
761018a 
"filter_source_repository" was just another name for "repository"
parameter.
 => Dropped it from api docu, but kept compat code to avoid
    api breakage

Clean'd up different internal method parameter namings, what could lead
to confusion about their meaning.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hennevogel hennevogel Awaiting requested review from hennevogel

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Backend Things regarding the OBS backend Documentation 📖 Things regarding our documentation Frontend Things related to the OBS RoR app
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adrianschroeter @dirkmueller @hennevogel