Introduce templates for new packages

[hellcp-work]

Introduces a simple template support to new project creation. Currently only supports one type of a package, SUSE style RPM, but it can be easily expanded to support everything that may be needed.

To verify:

1. Create a new project for templates
2. Set the OBS:PackageTemplates attribute on the project
3. Create a package in the template project
4. Create a file with name like: {{ package.name }}.extension.liquid and contents like {{ user.name }} (other options are in src/api/app/services/package_service/templater/{project,package,user}_drop.rb files)
5. Go to any other project
6. Click a create new package button
7. Write metadata about the new package
8. Select the template you created in the template project
9. Observe the package be initialized with a set of files

TODO:

• Create test data
• Create tests
• Write documentation for the feature (being worked on in a follow up PR)

[hellcp-work]

Explore new workflows multi file upload enables

[obs-bot]

Review app will appear here: http://obs-reviewlab.opensuse.org/hellcp-work-templates

[hennevogel]

This would require code changes and deployments for every template change. I'm not sure this is such a good idea.

[hellcp-work]

This would require code changes and deployments for every template change. I'm not sure this is such a good idea.

I went for a similar mechanism to image templates now. I implemented basic templating with liquid, in order to prefill some metadata, to avoid having to do that manually

[obs-bot]

Review app will appear here: http://obs-reviewlab.opensuse.org/hellcp-work-templates

[danidoni]

What happens if params['template'] does not have a '/' inside?

[hellcp-work]

It wouldn't work, I should do some validation here

[danidoni]

I think you can do the same without subqueries by adding :attrib_types into the join, right?

[hellcp-work]

Not sure, let me check

[hennevogel]

To verify:

• Create a new project for templates
  ...

You should do that in lib/tasks/dev/package-templates.rake and dev:test_data

[hellcp-work]

You should do that in lib/tasks/dev/package-templates.rake and dev:test_data

It's done in lib/tasks/dev/templates.rake and dev:test_data

[hennevogel]

I don't get it, is replacing Package/Project/User data the "feature" of those templates? Do we need to code and commit Liquid::Drop for each new object we want to fetch data from? What about data not from some object but from the form?

[hellcp-work]

I don't get it, is replacing Package/Project/User data the "feature" of those templates? Do we need to code and commit Liquid::Drop for each new object we want to fetch data from? What about data not from some object but from the form?

Yes, all data accessible from the template is specified by those drops. I wanted to avoid presenting data that we don't want to present, like User#password. The things in a form will be available via PackageDrop, since that's the package the user created with that metadata. Templates are unfortunately code, and keeping a minimal amount of access to the database is a good idea, since this feature if not done carefully, is an easy attack vector.