Some mkosi fixes

[Vogtinator]

With the .sha256 file generation, Repotype: checksumsfile should work.

CC @bluca

[bluca]

Any chance publishing the recipe can be salvaged? It is very nice to be able to reproduce them. Can they be in a directory named after the image or so?

[Vogtinator]

Any chance publishing the recipe can be salvaged? It is very nice to be able to reproduce them. Can they be in a directory named after the image or so?

To make them unique, they would have to be named after the package + multibuild flavor.

What's the use case you have in mind?

[bluca]

I don't have a specific use case in mind, just that I remember from when we added livebuild support, the fact that you could download images but not recipes without an account was an issue, and I didn't want a repeat. It's not a huge issue, if there's no alternative that's fine.

[mlschroe]

Your sha256 files contain the full path, which is probably not intended. How about something simpler like:

    for f in "$BUILD_ROOT/$TOPDIR"/OTHER/* ; do
        test -f "$f" && chroot "$BUILD_ROOT" sh -c "cd /$TOPDIR/OTHER && sha256sum \"${f##*/}\" > \"${f##*/}.sha256\""
    done

(untested)

[Vogtinator]

Your sha256 files contain the full path, which is probably not intended. How about something simpler like:

Indeed, fixed. Slightly differently though, with just a single chroot still

[Vogtinator]

I don't have a specific use case in mind, just that I remember from when we added livebuild support, the fact that you could download images but not recipes without an account was an issue, and I didn't want a repeat. It's not a huge issue, if there's no alternative that's fine.

IMO the repo shouldn't be used for publishing sources as-is, there are better ways for distribution. IMO the current state doesn't really make sense anyway as the recipe file on its own is incomplete without the other source files.

We can also keep the recipe file as build result and just ignore it during publishing. I'm wondering what we need it for, maybe for image build dependencies?

[bluca]

I don't have a specific use case in mind, just that I remember from when we added livebuild support, the fact that you could download images but not recipes without an account was an issue, and I didn't want a repeat. It's not a huge issue, if there's no alternative that's fine.

IMO the repo shouldn't be used for publishing sources as-is, there are better ways for distribution. IMO the current state doesn't really make sense anyway as the recipe file on its own is incomplete without the other source files.

We can also keep the recipe file as build result and just ignore it during publishing. I'm wondering what we need it for, maybe for image build dependencies?

The manifest is used for build dependencies, at least that was the intention in 1bead5d so yeah this should be fine to drop