Skip to content

Commit

Permalink
chore: address gosec warnings (#1648)
Browse files Browse the repository at this point in the history
## Checklist

- [x] I have read the [contribution
guidelines](https://github.com/ooni/probe-cli/blob/master/CONTRIBUTING.md)
- [x] reference issue for this pull request:
ooni/probe#2783
- [ ] if you changed anything related to how experiments work and you
need to reflect these changes in the ooni/spec repository, please link
to the related ooni/spec pull request: <!-- add URL here -->
- [ ] if you changed code inside an experiment, make sure you bump its
version number

<!-- Reminder: Location of the issue tracker:
https://github.com/ooni/probe -->

## Description

This diff addresses gosec warnings and tries to minimise them as much as
possible. The gosec warnings for the current `master` branch can be
found here:
https://github.com/ooni/probe-cli/actions/runs/10286957901/job/28468879578#step:6:1153.
  • Loading branch information
DecFox authored Aug 7, 2024
1 parent d915ab4 commit 98ab90e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion internal/testingx/oonibackendwithlogin.go
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ func (h *OONIBackendWithLoginFlow) handleOpenVPNConfig() http.Handler {

// we must lock because of SetOpenVPNConfig
h.mu.Lock()
w.Write(h.openVPNConfig)
_, _ = w.Write(h.openVPNConfig)
h.mu.Unlock()
})
}
Expand Down

0 comments on commit 98ab90e

Please sign in to comment.