Linting fixes

ooni · Apr 15, 2024 · 1cf537c · 1cf537c
1 parent 1fa3724
commit 1cf537c
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 6 deletions.
diff --git a/components/ThirdPartyDataChart.js b/components/ThirdPartyDataChart.js
@@ -58,6 +58,7 @@ const ThirdPartyDataChart = ({ since, until, country, asn, ...props }) => {
     return [from, to]
   }, [since, until])
 
+  // biome-ignore lint/correctness/useExhaustiveDependencies: <explanation>
   const cloudflareData = useEffect(() => {
     if (!since && !until) return
 

diff --git a/components/country/Overview.js b/components/country/Overview.js
@@ -59,11 +59,11 @@ const messages = defineMessages({
 const getStatus = (count, formattedMessageId) => {
   if (count === null) {
     return messages[`${formattedMessageId}NoData`]
-  } else if (count > 0) {
+  }
+  if (count > 0) {
     return messages[`${formattedMessageId}Blocked`]
-  } else {
-    return messages[`${formattedMessageId}Normal`]
   }
+  return messages[`${formattedMessageId}Normal`]
 }
 
 const ooniBlogBaseURL = 'https://ooni.org'
@@ -172,6 +172,7 @@ const Overview = ({
         ) : (
           <ul>
             {featuredArticles.map((article, index) => (
+              // biome-ignore lint/suspicious/noArrayIndexKey: <explanation>
               <li key={index}>
                 <FeaturedArticle link={article.href} title={article.title} />
               </li>

diff --git a/components/measurement/nettests/WebConnectivity.js b/components/measurement/nettests/WebConnectivity.js
@@ -1,9 +1,10 @@
 import bufferFrom from 'buffer-from'
 import NLink from 'next/link'
-import url from 'node:url'
 import { Box, Flex, Heading, Text } from 'ooni-components'
 import PropTypes from 'prop-types'
 import React from 'react'
+// biome-ignore lint/style/useNodejsImportProtocol: <explanation>
+import url from 'url'
 
 import deepmerge from 'deepmerge'
 import { Cross, Tick } from 'ooni-components/icons'

diff --git a/pages/domain/[domain].js b/pages/domain/[domain].js
@@ -111,7 +111,7 @@ const BlockingCountries = ({ blockedCountries }) => {
           { since, until },
         )}
       </Heading>
-      {!!blockedCountries?.length ? (
+      {blockedCountries?.length ? (
         <>
           <BlockText mb={3}>
             {intl.formatMessage({ id: 'Domain.CountriesBlocking.Subtitle' })}

diff --git a/pages/measurement/[[...report_id]].js b/pages/measurement/[[...report_id]].js
@@ -28,7 +28,7 @@ export async function getServerSideProps({ query }) {
     full: true,
   }
   if (query.input) {
-    params['input'] = query.input
+    params.input = query.input
   }
 
   let response