Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e): initial commit to setup playwright with devtools package #739

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

JessicaSachs
Copy link

@JessicaSachs JessicaSachs commented Sep 24, 2024

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Adding Playwright E2E testing to the developer workflow in order to catch regressions in browsers before they land in the stable channels of major browsers.

E2E Test TODOS

  • Install and configure Playwright
  • Add ability to launch and wait for internal server endpoint to return success code
  • Write a smoke test with Playwright E2E
  • Add a11y improvements to home page to be able to locate elements without coupling to DOM structure
  • Create a GHA to run Playwright in CI on PRs
  • Add package.json task to execute E2E tests locally (currently pnpm playwright test)

Cross-browser Test TODOS

Can be split out into its own PR. Adding Playwright without comprehensive cross-browser testing will still catch Chromium issues.

  • Set up SauceLabs to add cross-browser support for the smoke test
  • Add SauceLabs actions (Sauce Connect)
  • Add video to this PR and instructions to README/CONTRIBUTING file
  • Add package.json task to execute Sauce Labs-enabled E2E tests locally
  • Add .env.local details to document required environment variables
  • Create weekly/nightly Sauce Labs job to target Dev and Beta Chrome channels
  • Cut over credentials to Anthony/Nuxt Core team

@antfu
Copy link
Member

antfu commented Oct 12, 2024

Sorry for the delay. I think it would be safer to test against the production build - I will try to improve the test setup. Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants