Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[next] feat(NcDialogButton): Allow to return false from callback to keep dialog open #6035

Draft
wants to merge 2 commits into
base: next
Choose a base branch
from

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Aug 31, 2024

Backport of #6005

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Remove all the empty commits

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

susnux and others added 2 commits August 31, 2024 19:37
…ialog open

If the callback returns `false` then the click event will not be forwarded.
This could be usful if the click triggers a validation that fails and the user
should be able to fix the issue.

Co-authored-by: Ferdinand Thiessen <[email protected]>
Co-authored-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
@backportbot backportbot bot requested review from ShGKme, st3iny and susnux August 31, 2024 19:37
@backportbot backportbot bot added enhancement New feature or request 3. to review Waiting for reviews feature: dialog Related to the dialog component labels Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request feature: dialog Related to the dialog component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant