Enh/Align app navigation item counter in a better way #4991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Grigory Vodyanov <[email protected]>
susnux
previously approved these changes
Dec 23, 2023
| @@ -314,7 +314,7 @@ Just set the `pinned` prop. | |||
| <!-- Counter and Actions --> | |||
| <div v-if="hasUtils && !editingActive" | |||
| class="app-navigation-entry__utils" | |||
| :class="{'app-navigation-entry__utils--display-actions': forceDisplayActions || menuOpenLocalValue || menuOpen }"> | |||
| :class="{'app-navigation-entry__utils--display-actions': forceDisplayActions || menuOpenLocalValue || menuOpen, 'app-navigation-entry__utils--add-spacing': !hasChildren }"> | |||
There was a problem hiding this comment.
Maybe call it --has-children or something? Just to make it more descriptive?
susnux
added
enhancement
raimund-schluessler
requested changes
Dec 23, 2023
Signed-off-by: Grigory Vodyanov <[email protected]>
|
@raimund-schluessler Does this look better? |
Yes, better. But now the counter jumps to the right when the entry is hovered:
|
Could you please suggest how I could reproduce this? |
Go to the docs https://deploy-preview-4991--nextcloud-vue-components.netlify.app/#/Components/App%20containers/NcAppNavigation?id=ncappnavigationitem scroll to "Element with counter" and hover it. |
ShGKme
added
bug
|
Fixed in #6054 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🖼️ Screenshots
🏁 Checklist