Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed after show trigger call, this call was directing the focus to… #2736

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions src/components/Avatar/Avatar.vue
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,7 @@
placement="auto"
:container="menuContainer"
:open="contactsMenuOpenState"
@after-show="handlePopoverAfterShow"
@after-hide="handlePopoverAfterHide">
@after-show="handlePopoverAfterShow">
<PopoverMenu ref="popoverMenu" :menu="menu" />
<template #trigger>
<div v-if="contactsMenuLoading" class="icon-loading" />
Expand Down Expand Up @@ -455,10 +454,6 @@ export default {
links[0].focus()
}
},
handlePopoverAfterHide() {
// bring focus back to the trigger
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still a case that should be preserved when closing the menu with the keyboard I guess. This was introduced with #1854 for accessibility reasons.

this.$refs.main.focus()
},
handleUserStatusUpdated(state) {
if (this.user === state.userId) {
this.userStatus = {
Expand Down