Removed after show trigger call, this call was directing the focus to… #2736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the div of the DotsHorizontal component, making that when clicking outside the component the ... appear again
mstolf
added
bug
|
Can you rebase @mstolf :) |
juliusknorr
requested changes
Mar 24, 2023
| @@ -455,10 +454,6 @@ export default { | |||
| links[0].focus() | |||
| } | |||
| }, | |||
| handlePopoverAfterHide() { | |||
| // bring focus back to the trigger | |||
There was a problem hiding this comment.
This is still a case that should be preserved when closing the menu with the keyboard I guess. This was introduced with #1854 for accessibility reasons.
|
Is this still relevant? |
|
Closing as there is no activity for two years. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed after hide trigger call, this call was directing the focus to the div of the DotsHorizontal component, making that when clicking outside the component the "..." appear again
Fix #7459