Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
When using
ofType
with more than one type it would try to collapse those down into a single type, ieA | B
would become A if B was essentially the same as A but with a few extra properties. And if the types couldn't be collapsed because they were incompatible then you would just get an error requiring the generics to be manually filled intIssue Number: N/A
What is the new behavior?
The
ofType()
can now property infer types of unions wether they are similar or disparateDoes this PR introduce a breaking change?
Technically the generics of
ofType()
are changing so that the second parameter is an array rather than a union.I think this is relatively low risk as most people would be inferring the type and if someone is providing the generic it is probably because it couldn't be inferred which this should fix
Other information