Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor #120

Merged
merged 3 commits into from
Aug 22, 2023
Merged

Refactor #120

merged 3 commits into from
Aug 22, 2023

Conversation

ch3njust1n
Copy link
Contributor

Description

  1. Removed console logs
  2. Fixed Formik default values
  3. Refactored duplicate AutoCompleteInput components name space collision

Checklist

  • This PR can be reviewed in under 30 minutes
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have assigned reviewers to this PR.

@ch3njust1n
removed console logs, fixed formik default values, refactored duplica…
7399c8a 
…te AutoCompleteInput components namspace collision
gregfrasco
gregfrasco previously approved these changes Aug 22, 2023
View reviewed changes
Snafkin547
Snafkin547 previously approved these changes Aug 22, 2023
View reviewed changes
@ch3njust1n ch3njust1n dismissed stale reviews from Snafkin547 and gregfrasco August 22, 2023 15:52

The merge-base changed after approval.

@ch3njust1n ch3njust1n merged commit d3bcb14 into main Aug 22, 2023
1 check passed
@ch3njust1n ch3njust1n deleted the refactor branch August 22, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregfrasco gregfrasco gregfrasco left review comments

@Snafkin547 Snafkin547 Snafkin547 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ch3njust1n @gregfrasco @Snafkin547