Upgrade to rake-compiler-dock 1.5.1 #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since RE2 2024-06-01, the CI build for x86-linux and x86_64-linux slowed from around 15 minutes to almost an hour. This turned out to be due to the rake-compiler-dock images for those platforms having pkg-config 0.27.1 which performs very slowly with RE2's .pc file compared to more recent versions. This will instead use pkg-config 0.29.2 which should take a fraction of a second compared to the minutes 0.27.1 took to execute commands such as `pkg-config --libs-only-L --static re2.pc`. Thanks to @flavorjones for putting out a fix so promptly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since RE2 2024-06-01, the CI build for x86-linux and x86_64-linux slowed from around 15 minutes to almost an hour. This turned out to be due to the rake-compiler-dock images for those platforms having pkg-config 0.27.1 which performs very slowly with RE2's .pc file compared to more recent versions. This will instead use pkg-config 0.29.2 which should take a fraction of a second compared to the minutes 0.27.1 took to execute commands such as
pkg-config --libs-only-L --static re2.pc.Thanks to @flavorjones for putting out a fix so promptly.