Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gemfile #146

Merged
merged 5 commits into from
Feb 15, 2024
Merged

Update Gemfile #146

merged 5 commits into from
Feb 15, 2024

Conversation

yads
Copy link
Collaborator

@yads yads commented Feb 13, 2024

@dblock
Copy link
Contributor

dblock commented Feb 13, 2024

Want to finish the CI/CD started in #143 first?

@yads
Copy link
Collaborator Author

yads commented Feb 13, 2024

Good idea, there's more work that's needed on this PR anyway, but I'll pull the CI stuff in from that PR

* fix security vulnerability https://github.com/mongoid/mongoid_search/security/dependabot/1
* update various dependencies
@dblock
Copy link
Contributor

dblock commented Feb 14, 2024

@yads Tests are still failing, lmk if you need help.

* autofix rubocop errors
* ignore relevant_search specs
* ensure it works with github actions
* ensure it picks the highest version in each major release
jruby needs jruby-stemmer, perhaps this support can be added later
@yads
Copy link
Collaborator Author

yads commented Feb 14, 2024

@dblock I think I've got it going now, is there an automated way to generate the changelog entry?

@dblock
Copy link
Contributor

dblock commented Feb 15, 2024

@dblock I think I've got it going now, is there an automated way to generate the changelog entry?

Not today. Add a line saying something like "Replaced Travis-CI with GHA"?

@dblock dblock merged commit 4803493 into master Feb 15, 2024
21 checks passed
@dblock dblock mentioned this pull request Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants