MONGOID-5805 Short-circuit the logic in extract_attribute to fix performance regression (backport to 8.1-stable) #5869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comandeo-mongo
approved these changes
Sep 23, 2024
jamis
added a commit
to jamis/mongoid
that referenced
this pull request
Oct 16, 2024
…ormance regression (backport to 8.1-stable) (mongodb#5869) * short-circuit the logic in extract_attribute to fix performance regression * short circuit on anything that's not a document or hash * handle hash/string keys
jamis
added a commit
that referenced
this pull request
Oct 17, 2024
* MONGOID-5815 Respect client_override for new docs (#5880) * MONGOID-5805 Short-circuit the logic in extract_attribute to fix performance regression (backport to 8.1-stable) (#5869) * short-circuit the logic in extract_attribute to fix performance regression * short circuit on anything that's not a document or hash * handle hash/string keys --------- Co-authored-by: Dmitry Rybakov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a performance regression caused by always splitting keys at
.characters, whether the string has them or not. By short-circuiting the common case, we can recover a significant performance improvement. (Backport from master.)