Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MONGOID-5615 Allow use key_alt_name #5665

Merged
merged 6 commits into from
Jul 13, 2023
Merged

MONGOID-5615 Allow use key_alt_name #5665

merged 6 commits into from
Jul 13, 2023

Conversation

comandeo
Copy link
Contributor

No description provided.

@comandeo comandeo requested review from jamis and alexbevi July 12, 2023 15:39
jamis
jamis approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@jamis jamis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Just one place where an exception message needs to be fleshed out, but other than that, 👍 . Marking it approved because I've got no material objections. :)

lib/mongoid/config/encryption.rb Outdated Show resolved Hide resolved
@comandeo comandeo marked this pull request as ready for review July 13, 2023 08:16
@comandeo comandeo merged commit 0aaf865 into mongodb:master Jul 13, 2023
17 checks passed
@comandeo comandeo deleted the 5615-key-alt-names branch July 13, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamis jamis jamis approved these changes

@alexbevi alexbevi alexbevi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@comandeo @jamis @alexbevi @comandeo-mongo