-
-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support lifecycyle hooks in module-deferation bridge #2992
Open
danpeen
wants to merge
29
commits into
main
Choose a base branch
from
feat/bridge-lifecycle-hook
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 25 commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
3118053
feat: add hook when snapshot is ready
nyqykk 3082116
feat: support isolated report
nyqykk f716f18
chore: merge main
nyqykk edaffa2
Merge branch 'main' into feat/isolated-monitor
nyqykk 62480b6
feat: support bridge lifecycle
nyqykk c868988
Merge branch 'feat/isolated-monitor' of github.com:module-federation/…
nyqykk cf83897
chore: modify bridge lifecycle
nyqykk aa05fc5
chore: change symbol name for module
nyqykk 8aebc66
chore: sync main code
nyqykk e414ded
feat: add vue3 bridge lifecycle
nyqykk f575ec7
chore: export bridge plugin type
nyqykk fe9ad08
Merge branch 'main' into feat/isolated-monitor
nyqykk 7257784
chore: sync branch
nyqykk 74f057a
chore: merge main branch
danpeen 14a30fa
fix: fix router ci failed issue
danpeen b47ea80
feat: update bridge render hook name
danpeen b02d9f0
chore: merge main branch
danpeen 93627d9
chore: merge main branch
danpeen 5e33da2
feat: update bridge hook
danpeen 83e54ad
feat: update bridge lifecycle register logic in bridge-vue
danpeen 2fac2ea
fix: bridge should use raw basename from application router itself
danpeen 4e319bb
Merge branch 'main' into feat/bridge-lifecycle-hook
ScriptedAlchemy a891716
feat: add params to pass bridge hooks
danpeen 5c7f0be
chore: merge main branch
danpeen a6c9c97
feat: add afterBridgeRender hook and afterBridgeDestroy hook
danpeen 10bc78b
feat: receive extraProps from rederhook
danpeen 19acf8b
feat: receive extraProps from rederhook update
danpeen 25d850b
feat: add default className for bridge root component
danpeen 8588609
chore: merge main branch
danpeen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
--- | ||
'@module-federation/bridge-react': patch | ||
'@module-federation/bridge-vue3': patch | ||
'@module-federation/runtime': patch | ||
--- | ||
|
||
feat: support module isolated reported |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
import { getInstance } from '@module-federation/runtime'; | ||
import helper from '@module-federation/runtime/helpers'; | ||
|
||
function registerBridgeLifeCycle() { | ||
const { registerPlugins, pluginHelper } = helper.global; | ||
const host = getInstance(); | ||
const pluginSystem = new pluginHelper.PluginSystem({ | ||
beforeBridgeRender: new pluginHelper.SyncHook< | ||
[Record<string, any>], | ||
void | ||
>(), | ||
beforeBridgeDestroy: new pluginHelper.SyncHook< | ||
[Record<string, any>], | ||
void | ||
>(), | ||
}); | ||
|
||
if (host) { | ||
registerPlugins<typeof pluginSystem.lifecycle, typeof pluginSystem>( | ||
host?.options?.plugins, | ||
[pluginSystem], | ||
); | ||
return pluginSystem; | ||
} | ||
|
||
return null; | ||
} | ||
|
||
export { registerBridgeLifeCycle }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
import { getInstance } from '@module-federation/runtime'; | ||
import helper from '@module-federation/runtime/helpers'; | ||
|
||
function registerBridgeLifeCycle() { | ||
const { registerPlugins, pluginHelper } = helper.global; | ||
const host = getInstance(); | ||
const pluginSystem = new pluginHelper.PluginSystem({ | ||
beforeBridgeRender: new pluginHelper.SyncHook< | ||
[Record<string, any>], | ||
void | ||
>(), | ||
beforeBridgeDestroy: new pluginHelper.SyncHook< | ||
[Record<string, any>], | ||
void | ||
>(), | ||
}); | ||
|
||
if (host) { | ||
registerPlugins<typeof pluginSystem.lifecycle, typeof pluginSystem>( | ||
host?.options?.plugins, | ||
[pluginSystem], | ||
); | ||
return pluginSystem; | ||
} | ||
|
||
return null; | ||
} | ||
|
||
export { registerBridgeLifeCycle }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i wonder if we should make this use named exports in the future, so that better tree shake or destructure is possible later. (for the helpers stuff)
import {global} from helper