Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MIDI for light: add settings ui #13721

Open
wants to merge 3 commits into
base: 2.5
Choose a base branch
from

Conversation

ekordas
Copy link
Contributor

@ekordas ekordas commented Oct 6, 2024

Adds Setting definition for UI of the Midi for Light Script

@ronso0
Copy link
Member

ronso0 commented Oct 6, 2024

Thank you for this PR.
Please sign the Mixxx Contributor Agreement and comment here when you have done so. It gives us permission to distribute your contribution under the GPL v2 or later license and the Apple Mac App Store. It is also helpful for us to have contact information for contributors in case we may need it in the future.

Do you mind attaching a screenshot of the new settings?

@ekordas
Copy link
Contributor Author

ekordas commented Oct 6, 2024

I allready signed the agreement.

Here is a screenshot:
midi_for_light-settings

@ronso0
Copy link
Member

ronso0 commented Oct 6, 2024

Okay, thank you, I didn't remember you already worked on MIDI for lights.

The VU checkboxes could use more human-readable labels, not just the internal variable names, no?

I didn't work with the controller settings, yet, wasn't there an option/flag that would arange group items horizontally if the preference page allows it?

@ekordas
Copy link
Contributor Author

ekordas commented Oct 6, 2024

I didnt work with the controller settings either, If there is a documentation for it i can set other flags. Leaving the Orientation to unset flipps checkboxes to a row while resizing the settings wich is really destroying the layout:
Bildschirmfoto vom 2024-10-07 00-00-49
So i leave it to vertical.
The Labels are changed in the next commit.

@JoergAtGithub
Copy link
Member

If there is a documentation for it i can set other flags.

@acolombier Do we have this described in the manual?

The best reference is the mapping for the S4 Mk3: #12995

@ekordas
Copy link
Contributor Author

ekordas commented Oct 6, 2024

The Mapping xml file is described at https://github.com/mixxxdj/mixxx/wiki/MIDI%20controller%20mapping%20file%20format but not the ui Stuff. I Used the mentioned diff as reference.

@ekordas
Copy link
Contributor Author

ekordas commented Oct 6, 2024

The<row orientation="vertical">seems to do the intended behavior, but if the vertical list of checkboxes is flipped to a row it does not flip back. And it does not matter how slim you resize the window.
The section above does change to a row if the Size allows it and back, but it seems there is a Problem with a long list of checkboxes.
Since the script is more aimed at developers and technical applications I personally would not bother making it pretty to much. It only requires a little scrolling.
Following is a new attempt:
Bildschirmfoto vom 2024-10-07 00-52-49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants