Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency webpack-dev-middleware to v5 [security] #5373

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Mar 22, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
webpack-dev-middleware ^1.9.0 -> ^5.0.0 age adoption passing confidence

GitHub Vulnerability Alerts

CVE-2024-29180

Summary

The webpack-dev-middleware middleware does not validate the supplied URL address sufficiently before returning the local file. It is possible to access any file on the developer's machine.

Details

The middleware can either work with the physical filesystem when reading the files or it can use a virtualized in-memory memfs filesystem.
If writeToDisk configuration option is set to true, the physical filesystem is used:
https://github.com/webpack/webpack-dev-middleware/blob/7ed24e0b9f53ad1562343f9f517f0f0ad2a70377/src/utils/setupOutputFileSystem.js#L21

The getFilenameFromUrl method is used to parse URL and build the local file path.
The public path prefix is stripped from the URL, and the unsecaped path suffix is appended to the outputPath:
https://github.com/webpack/webpack-dev-middleware/blob/7ed24e0b9f53ad1562343f9f517f0f0ad2a70377/src/utils/getFilenameFromUrl.js#L82
As the URL is not unescaped and normalized automatically before calling the midlleware, it is possible to use %2e and %2f sequences to perform path traversal attack.

PoC

A blank project can be created containing the following configuration file webpack.config.js:
module.exports = { devServer: { devMiddleware: { writeToDisk: true } } };

When started, it is possible to access any local file, e.g. /etc/passwd:
$ curl localhost:8080/public/..%2f..%2f..%2f..%2f../etc/passwd

root:x:0:0:root:/root:/bin/bash
daemon:x:1:1:daemon:/usr/sbin:/usr/sbin/nologin
bin:x:2:2:bin:/bin:/usr/sbin/nologin
sys:x:3:3:sys:/dev:/usr/sbin/nologin
sync:x:4:65534:sync:/bin:/bin/sync
games:x:5:60:games:/usr/games:/usr/sbin/nologin

Impact

The developers using webpack-dev-server or webpack-dev-middleware are affected by the issue. When the project is started, an attacker might access any file on the developer's machine and exfiltrate the content (e.g. password, configuration files, private source code, ...).

If the development server is listening on a public IP address (or 0.0.0.0), an attacker on the local network can access the local files without any interaction from the victim (direct connection to the port).

If the server allows access from third-party domains (CORS, Allow-Access-Origin: * ), an attacker can send a malicious link to the victim. When visited, the client side script can connect to the local server and exfiltrate the local files.

Recommendation

The URL should be unescaped and normalized before any further processing.


Release Notes

webpack/webpack-dev-middleware (webpack-dev-middleware)

v5.3.4

Compare Source

5.3.4 (2024-03-20)
Bug Fixes

v5.3.3

Compare Source

v5.3.2

Compare Source

v5.3.1

Compare Source

v5.3.0

Compare Source

Features
5.2.2 (2021-11-17)
Chore
  • update schema-utils package to 4.0.0 version
5.2.1 (2021-09-25)
  • internal release, no visible changes and features

v5.2.2

Compare Source

v5.2.1

Compare Source

  • internal release, no visible changes and features

v5.2.0

Compare Source

Features

v5.1.0

Compare Source

Features
  • don't read full file if Range header is present (e8b21f0)
  • output more information on errors (#​1024) (7df9e44)
Bug Fixes

v5.0.0

Compare Source

⚠ BREAKING CHANGES

v4.3.0

Compare Source

Features
Bug Fixes

v4.2.0

Compare Source

Features

v4.1.0

Compare Source

Features
4.0.4 (2021-01-13)
Bug Fixes
4.0.3 (2021-01-12)
Bug Fixes
  • output stats to stdout instead stderr, how does webpack-cli, if you need hide stats from output please use { stats: false } or { stats: 'none' } (4de0f97)
  • colors are working for stats (4de0f97)
  • schema description (#​783) (f9ce2b2)
  • skip Content-type header on unknown types (#​809) (5c9eee5)
4.0.2 (2020-11-10)
Bug Fixes
4.0.1 (2020-11-09)
Bug Fixes
  • compatibility with connect (b83a1db)

v4.0.4

Compare Source

v4.0.3

Compare Source

v4.0.2

Compare Source

v4.0.1

Compare Source

v4.0.0

Compare Source

⚠ BREAKING CHANGES
  • export in CommonJS format
Bug Fixes

v3.7.3

Compare Source

3.7.3 (2020-12-15)
Bug Fixes

v3.7.2

Compare Source

v3.7.1

Compare Source

v3.7.0

Compare Source

Features

v3.6.2

Compare Source

Bug Fixes
  • check existence of res.getHeader and set the correct Content-Type (#​385) (56dc705)

v3.6.1

Compare Source

Bug Fixes
  • do not overwrite Content-Type if header already exists (#​377) (b2a6fed)

v3.6.0

Compare Source

Features

v3.5.2

Compare Source

Bug Fixes

v3.5.1

Compare Source

Bug Fixes
  • remove querystring from filenames when writing to disk (#​361) (90d0d94)

v3.5.0

Compare Source

Bug Fixes
Features
  • allow to redefine mimeTypes (possible to use force option) (#​349) (e56a181)

v3.4.0

Compare Source

Bug Fixes
  • index: don't modify the default behavior for unhandledRejection (#​340) (f0a8e3e)
  • middleware: replace url-join with path.posix.join (#​334) (d75802b)

v3.3.0

Compare Source

Features
  • middleware: expose the memory filesystem (response.locals.fs) (#​337) (f9a138e)

v3.2.0

Compare Source

Bug Fixes
Features
  • middleware: add methods option (options.methods) (#​319) (fe6bb86)

v3.1.3

Compare Source

Bugfixes

  • Excluded outputPath from URI escaping to fix #​297. (#​303)
  • fix: fixes #​290 - MultiCompiler exception with writeToDisk (#​301)

v3.1.2

Compare Source

Updates

  • refactor: use chalk from webpack-log (#​293)

v3.1.1

Compare Source

Bugfixes

  • fix(package): add chalk to peerDeps (#​292)

v3.1.0

Compare Source

Bugfixes

Features

  • Allow Writing Files to Disk (#​287)

v3.0.1

Compare Source

v3.0.0

Compare Source

Updates

  • Webpack 4 (#​267)
  • remove watchOffset option in favor of time-fix-plugin

Breaking Changes

  • Introduces full support for webpack v4 and removes support for lesser versions.
  • The watchOffset option has been removed and the README has been updated with alternative means of accomplishing the same result for this module and webpack v4.
  • middleware.webpack now returns a Promise that should be handled with .then when needing to perform other actions, like adding additional middleware.

v2.0.6

Compare Source

v2.0.5

Compare Source

v2.0.4

Compare Source

v2.0.3

Compare Source

v2.0.2

Compare Source

Updates

  • Implemented webpack-log, removed dependencies related to the previous logging implementation.

v2.0.1

Compare Source

Publish to correct package.json.

v2.0.0

Compare Source

This major release introduces a comprehensive refactor of the codebase and move to leverage more ES6 as supported by Node 6+. It also introduced a number of breaking changes, as outlined below.

Node Version Support

webpack-dev-middleware version 2 and higher will only support Node 6.x and higher. Active
LTS for Node 4.x ended October 31st, 2017 and entered maintenance on that date.
Likewise, the version 1.x branch of webpack-dev-middleware will enter maintenance on
that date.

Informative Changes

  • logging is now handled by log-level and follows the same patterns as
    webpack-dev-server.

Breaking Changes

  • watchDelay option was previous deprecated and has now been removed.
  • reportTime option renamed to logTime
  • noInfo option removed in favor of setting a logLevel higher than 'info'
  • quiet option removed in favor of logLevel: 'silent'
  • reporter signature changed to reporter(middlewareOptions, reporterOptions)

Configuration

📅 Schedule: Branch creation - "" in timezone US/Eastern, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

Copy link
Contributor Author

renovate bot commented Mar 22, 2024

⚠ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: yarn.lock
/opt/containerbase/tools/corepack/0.28.0/14.18.2/node_modules/corepack/dist/yarn.js:2
process.env.COREPACK_ENABLE_DOWNLOAD_PROMPT??='1'
                                           ^^^

SyntaxError: Unexpected token '??='
    at wrapSafe (internal/modules/cjs/loader.js:1001:16)
    at Module._compile (internal/modules/cjs/loader.js:1049:27)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1114:10)
    at Module.load (internal/modules/cjs/loader.js:950:32)
    at Function.Module._load (internal/modules/cjs/loader.js:790:12)
    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:76:12)
    at internal/main/run_main_module.js:17:47

@renovate renovate bot force-pushed the renovate/npm-webpack-dev-middleware-vulnerability branch from 398a6a5 to 1c3d0fb Compare March 26, 2024 12:44
@renovate renovate bot changed the title Update dependency webpack-dev-middleware to v5 [SECURITY] fix(deps): update dependency webpack-dev-middleware to v5 [security] Mar 26, 2024
@renovate renovate bot force-pushed the renovate/npm-webpack-dev-middleware-vulnerability branch from 1c3d0fb to 9d0c985 Compare March 26, 2024 14:38
@renovate renovate bot force-pushed the renovate/npm-webpack-dev-middleware-vulnerability branch from 9d0c985 to e2060f3 Compare April 2, 2024 15:06
@renovate renovate bot force-pushed the renovate/npm-webpack-dev-middleware-vulnerability branch 2 times, most recently from 430c158 to e8de645 Compare April 17, 2024 12:04
@renovate renovate bot force-pushed the renovate/npm-webpack-dev-middleware-vulnerability branch 4 times, most recently from eb4093c to 1198166 Compare April 25, 2024 18:08
@renovate renovate bot force-pushed the renovate/npm-webpack-dev-middleware-vulnerability branch from 1198166 to ca1f55a Compare May 3, 2024 15:47
@renovate renovate bot force-pushed the renovate/npm-webpack-dev-middleware-vulnerability branch from ca1f55a to 4435207 Compare May 20, 2024 18:27
Copy link
Contributor Author

renovate bot commented May 20, 2024

⚠️ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: yarn.lock
/opt/containerbase/tools/corepack/0.29.4/14.18.2/node_modules/corepack/dist/yarn.js:2
process.env.COREPACK_ENABLE_DOWNLOAD_PROMPT??='1'
                                           ^^^

SyntaxError: Unexpected token '??='
    at wrapSafe (internal/modules/cjs/loader.js:1001:16)
    at Module._compile (internal/modules/cjs/loader.js:1049:27)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1114:10)
    at Module.load (internal/modules/cjs/loader.js:950:32)
    at Function.Module._load (internal/modules/cjs/loader.js:790:12)
    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:76:12)
    at internal/main/run_main_module.js:17:47

@renovate renovate bot force-pushed the renovate/npm-webpack-dev-middleware-vulnerability branch from 4435207 to 62748b6 Compare May 20, 2024 19:54
@renovate renovate bot force-pushed the renovate/npm-webpack-dev-middleware-vulnerability branch from 62748b6 to 40378cd Compare May 28, 2024 20:07
@renovate renovate bot force-pushed the renovate/npm-webpack-dev-middleware-vulnerability branch 2 times, most recently from af90a40 to 6918d8d Compare June 17, 2024 15:12
@renovate renovate bot force-pushed the renovate/npm-webpack-dev-middleware-vulnerability branch 3 times, most recently from 2a6bf5a to c5cc8bd Compare October 7, 2024 19:20
@renovate renovate bot force-pushed the renovate/npm-webpack-dev-middleware-vulnerability branch from c5cc8bd to 332cf85 Compare October 17, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants