Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency tornado to v6 [security] #5361

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Oct 24, 2023

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
tornado (source) ==5.1.1 -> ==6.3.3 age adoption passing confidence

GitHub Vulnerability Alerts

CVE-2023-28370

Open redirect vulnerability in Tornado versions 6.3.1 and earlier allows a remote unauthenticated attacker to redirect a user to an arbitrary web site and conduct a phishing attack by having user access a specially crafted URL.

GHSA-qppv-j76h-2rpx

Summary

Tornado interprets -, +, and _ in chunk length and Content-Length values, which are not allowed by the HTTP RFCs. This can result in request smuggling when Tornado is deployed behind certain proxies that interpret those non-standard characters differently. This is known to apply to older versions of haproxy, although the current release is not affected.

Details

Tornado uses the int constructor to parse the values of Content-Length headers and chunk lengths in the following locations:

tornado/http1connection.py:445

            self._expected_content_remaining = int(headers["Content-Length"])

tornado/http1connection.py:621

                content_length = int(headers["Content-Length"])  # type: Optional[int]

tornado/http1connection.py:671

            chunk_len = int(chunk_len_str.strip(), 16)

Because int("0_0") == int("+0") == int("-0") == int("0"), using the int constructor to parse and validate strings that should contain only ASCII digits is not a good strategy.


Release Notes

tornadoweb/tornado (tornado)

v6.3.3

Compare Source

v6.3.2

Compare Source

v6.3.1

Compare Source

v6.3

Compare Source

v6.2

Compare Source

v6.1

Compare Source

v6.0.4

Compare Source

v6.0.3

Compare Source

v6.0.2

Compare Source

v6.0.1

Compare Source

v6.0

Compare Source


Configuration

📅 Schedule: Branch creation - "" in timezone US/Eastern, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot force-pushed the renovate/pypi-tornado-vulnerability branch from 566f9fa to 43c8e55 Compare February 5, 2024 19:52
@renovate renovate bot changed the title chore(deps): update dependency tornado to v6 [security] Update dependency tornado to v6 [SECURITY] Feb 6, 2024
@renovate renovate bot force-pushed the renovate/pypi-tornado-vulnerability branch from 43c8e55 to e7f89ab Compare February 6, 2024 16:17
@renovate renovate bot force-pushed the renovate/pypi-tornado-vulnerability branch 3 times, most recently from 55185d3 to 7ea5cf7 Compare March 6, 2024 13:54
@renovate renovate bot force-pushed the renovate/pypi-tornado-vulnerability branch 2 times, most recently from e8d2aa1 to 4bbd149 Compare March 26, 2024 12:43
@renovate renovate bot changed the title Update dependency tornado to v6 [SECURITY] chore(deps): update dependency tornado to v6 [security] Mar 26, 2024
@renovate renovate bot force-pushed the renovate/pypi-tornado-vulnerability branch from 4bbd149 to beb5050 Compare March 26, 2024 14:38
@renovate renovate bot force-pushed the renovate/pypi-tornado-vulnerability branch from beb5050 to 7967645 Compare April 2, 2024 15:06
@renovate renovate bot force-pushed the renovate/pypi-tornado-vulnerability branch 2 times, most recently from af2aae4 to 485cf59 Compare April 17, 2024 12:03
@renovate renovate bot force-pushed the renovate/pypi-tornado-vulnerability branch 3 times, most recently from 72bd66e to 3b490ed Compare April 24, 2024 12:44
@shanbady shanbady self-assigned this Apr 25, 2024
@shanbady shanbady self-requested a review April 25, 2024 13:45
@renovate renovate bot force-pushed the renovate/pypi-tornado-vulnerability branch from 3b490ed to 020dfb2 Compare April 25, 2024 13:46
@annagav annagav self-requested a review April 25, 2024 17:22
Copy link
Contributor

@annagav annagav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to run the app locally access the public pages and personal dashboard, as well as the admin. 👍

@renovate renovate bot force-pushed the renovate/pypi-tornado-vulnerability branch from 020dfb2 to 758337d Compare April 25, 2024 18:08
@renovate renovate bot force-pushed the renovate/pypi-tornado-vulnerability branch from 758337d to e8e7e5a Compare May 3, 2024 15:46
@renovate renovate bot force-pushed the renovate/pypi-tornado-vulnerability branch 2 times, most recently from 73b9a48 to dce94b4 Compare May 20, 2024 19:54
@renovate renovate bot force-pushed the renovate/pypi-tornado-vulnerability branch from dce94b4 to 28fa207 Compare May 28, 2024 20:07
@renovate renovate bot force-pushed the renovate/pypi-tornado-vulnerability branch from 28fa207 to 690939f Compare June 6, 2024 23:27
@renovate renovate bot force-pushed the renovate/pypi-tornado-vulnerability branch 2 times, most recently from 7625ef6 to ee35efd Compare June 17, 2024 15:12
@renovate renovate bot force-pushed the renovate/pypi-tornado-vulnerability branch from ee35efd to 178f78d Compare August 6, 2024 09:41
@renovate renovate bot force-pushed the renovate/pypi-tornado-vulnerability branch 3 times, most recently from 07736df to 82dfb59 Compare October 7, 2024 19:19
@renovate renovate bot force-pushed the renovate/pypi-tornado-vulnerability branch from 82dfb59 to d572078 Compare October 17, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants