Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile: replace Risal, Philippines with Rizal #4653

Closed
pdpinch opened this issue Sep 25, 2020 · 3 comments · Fixed by mitodl/iso-3166-2.js#3 or #4658
Closed

Profile: replace Risal, Philippines with Rizal #4653

pdpinch opened this issue Sep 25, 2020 · 3 comments · Fixed by mitodl/iso-3166-2.js#3 or #4658
Assignees

Comments

@pdpinch
Copy link
Member

pdpinch commented Sep 25, 2020

reported in https://odl.zendesk.com/agent/tickets/57751

Steps to Reproduce

  1. Log in and go to /profile/personal
  2. Under "Where are you currently living" set the Country to "Philippines"
  3. Open the drop-down for "State or Territory"

Expected Behavior

  • you can choose the state "Rizal"

Actual Behavior

  • the state is spelled "Risal"

Notes

You can confirm this is the correct English spelling for the state in Wikipedia.

We should make this change in our fork of the iso-3166-2.js library and then open a pull request upstream.

@HamzaIbnFarooq
Copy link
Contributor

HamzaIbnFarooq commented Oct 8, 2020

@pdpinch should we create a PR from the master of mitodl fork to the upstream or just a PR to fix the "Rizal" state-name issue?
FYI: our fork currently has the following changes:

  1. English translation of Israel states
  2. Add a country named Kosovo
  3. Philippines state Rizal name typo fix

@HamzaIbnFarooq
Copy link
Contributor

Upstream PR: olahol/iso-3166-2.js#32

@pdpinch
Copy link
Member Author

pdpinch commented Oct 16, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants