Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing state's name by replacing Risal with Rizal #3

Merged
merged 1 commit into from
Oct 8, 2020

Conversation

HamzaIbnFarooq
Copy link

@HamzaIbnFarooq HamzaIbnFarooq commented Oct 6, 2020

What are the relevant tickets?

fixes mitodl/micromasters#4653

What's this PR do?

Fixes typo in a state's name by replacing Risal with Rizal

How to test?

On micromaster do the following steps:

  1. Log in and go to /profile/personal
  2. Under "Where are you currently living" set the Country to "Philippines"
  3. Open the drop-down for "State or Territory"
  4. Search for state "Rizal", you will see "Risal" instead.

Now go to the package.json of micromasters and change iso-3166-2 dependency's commit id with hamza/replace-Risal-by-Rizal (ie: "iso-3166-2": "https://github.com/mitodl/iso-3166-2.js/#hamza/replace-Risal-by-Rizal",)
Now govern the same 4 steps mentioned above, you will see that now "Rizal" is showing up.

OR you can also test it by:

iso3166.subdivision("PH", "RIZ")
{
  type: 'Province',
  name: 'Rizal',      # new name
  countryName: 'Philippines',
  countryCode: 'PH',
  code: 'PH-RIZ',
  regionCode: 'RIZ'
}

Screenshots:

Before:
image
After:
image

Copy link

@umarmughal824 umarmughal824 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality-wise looks good.

Copy link

@umarmughal824 umarmughal824 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@umarmughal824
Copy link

umarmughal824 commented Oct 8, 2020

@HamzaIbnFarooq make sure to create the micromasters corresponding PR for the updated iso-3366.js with your commit version and give the reference of that PR and assign that new PR for review to me.

@HamzaIbnFarooq
Copy link
Author

@HamzaIbnFarooq make sure to create the micromasters corresponding PR for the updated iso-3366.js with your commit version and give the reference of that PR and assign that new PR for review to me.

Thanks @umarmughal824 for the remainder, will do once this PR gets merged.

@HamzaIbnFarooq HamzaIbnFarooq merged commit 918e407 into master Oct 8, 2020
@HamzaIbnFarooq HamzaIbnFarooq deleted the hamza/replace-Risal-by-Rizal branch October 8, 2020 09:45
@HamzaIbnFarooq HamzaIbnFarooq restored the hamza/replace-Risal-by-Rizal branch October 8, 2020 10:47
@HamzaIbnFarooq HamzaIbnFarooq deleted the hamza/replace-Risal-by-Rizal branch October 8, 2020 11:54
@HamzaIbnFarooq HamzaIbnFarooq restored the hamza/replace-Risal-by-Rizal branch October 16, 2020 05:59
@HamzaIbnFarooq HamzaIbnFarooq deleted the hamza/replace-Risal-by-Rizal branch October 16, 2020 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Profile: replace Risal, Philippines with Rizal
2 participants