-
Notifications
You must be signed in to change notification settings - Fork 689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: logic for archiving dataroom #1051
base: main
Are you sure you want to change the base?
Conversation
@Khaan25 is attempting to deploy a commit to the mftsio Team on Vercel. A member of the Team first needs to authorize it. |
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
@Khaan25 looks good so far
|
Yes, I'm gonna work on it |
Hey, In the Link table, we've isArchived field, is that for any other usecase? |
Here's a video: https://streamable.com/0yl2ym Could not upload more than 10 MBs of video on GitHub :) |
…/Khaan25/papermark into feat/ability-to-archive-dataroom
You can see the image above, if we're on trial and we create dataroom then the trial-banner day isn't showing because it's fetching from the first data-room tab in the image, how about we proceed? My initial thoughts are, query for first tab, if null then query for second tab, that way we won't have "days left" but "X days left" What do you say? |
This PR fixes: #785
I've included a boolean in the function to archive a dataroom.
Will discuss some key points with @mfts and finish this feature.