Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: logic for archiving dataroom #1051

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Khaan25
Copy link

@Khaan25 Khaan25 commented Oct 16, 2024

This PR fixes: #785

I've included a boolean in the function to archive a dataroom.

Will discuss some key points with @mfts and finish this feature.

@Khaan25 Khaan25 requested a review from mfts as a code owner October 16, 2024 06:27
Copy link

vercel bot commented Oct 16, 2024

@Khaan25 is attempting to deploy a commit to the mftsio Team on Vercel.

A member of the Team first needs to authorize it.

Copy link


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@mfts
Copy link
Owner

mfts commented Oct 16, 2024

@Khaan25 looks good so far

  • missing a field on Dataroom table for isArchived
  • also missing the tab for the archived datarooms

@Khaan25
Copy link
Author

Khaan25 commented Oct 17, 2024

Yes, I'm gonna work on it

@Khaan25
Copy link
Author

Khaan25 commented Oct 17, 2024

Hey, In the Link table, we've isArchived field, is that for any other usecase?

@Khaan25
Copy link
Author

Khaan25 commented Oct 17, 2024

image

Here's a video: https://streamable.com/0yl2ym

Could not upload more than 10 MBs of video on GitHub :)
FYI, Video link expires after 2 days :)

@Khaan25
Copy link
Author

Khaan25 commented Oct 17, 2024

Just a quick question,
image

You can see the image above, if we're on trial and we create dataroom then the trial-banner day isn't showing because it's fetching from the first data-room tab in the image, how about we proceed?

My initial thoughts are, query for first tab, if null then query for second tab, that way we won't have "days left" but "X days left"

What do you say?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🕹️] Add the ability to archive a dataroom
2 participants