Merge pull request #449 from anshg1214/fix_bb_eg

Add Title for Edition Group's page
metabrainz · Jul 25, 2022 · e1265da · e1265da
2 parents 28e2ec3 + e1b1c93
commit e1265da
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/critiquebrainz/frontend/external/bookbrainz_db/edition_group.py b/critiquebrainz/frontend/external/bookbrainz_db/edition_group.py
@@ -23,7 +23,7 @@ def get_edition_group_by_bbid(bbid: uuid.UUID) -> dict:
             - disambiguation: Disambiguation of the edition group.
             - identifiers: A list of dictionaries containing the basic information on the identifiers.
             - rels: A list of dictionaries containing the basic information on the relationships.
-            - artist_credits: A list of dictionaries containing the basic information on the artist credits.
+            - author_credits: A list of dictionaries containing the basic information on the author credits.
 
         Returns None if the edition group is not found.
 
@@ -60,7 +60,7 @@ def fetch_multiple_edition_groups(bbids: List[uuid.UUID]) -> dict:
                     disambiguation,
                     identifier_set_id,
                     relationship_set_id,
-                    json_agg( acn ORDER BY "position" ASC ) as artist_credits
+                    json_agg( acn ORDER BY "position" ASC ) as author_credits
                FROM edition_group 
           LEFT JOIN author_credit_name acn ON acn.author_credit_id = edition_group.author_credit_id 
               WHERE bbid in :bbids

diff --git a/critiquebrainz/frontend/templates/bb_edition_group/entity.html b/critiquebrainz/frontend/templates/bb_edition_group/entity.html
@@ -2,6 +2,7 @@
 {% from 'macros.html' import show_avg_rating, entity_rate_form, show_review_buttons with context %}
 {% from 'common.html' import rating_script with context %}
 
+{% block title %}{{ edition_group.name }} - CritiqueBrainz{% endblock %}
 
 {% block content %}
 <div class="clearfix">

diff --git a/critiquebrainz/frontend/templates/review/entity/bb_edition_group.html b/critiquebrainz/frontend/templates/review/entity/bb_edition_group.html
@@ -2,6 +2,10 @@
 
 {% set bb_edition_group = entity %}
 
+{% block title %}
+  {{ _('Review of "%(edition_group)s" by %(user)s', edition_group=bb_edition_group.name, user=review.user.display_name) }} - CritiqueBrainz
+{% endblock %}
+
 {% block entity_title %}
   <h2 id="title">
     {% set edition_group_name = '<a href="%s">' | safe % url_for('bb_edition_group.entity', id=review.entity_id) ~ bb_edition_group.name ~ '</a>'|safe %}