Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rediscache concurrent access #72

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

juntaki
Copy link

@juntaki juntaki commented Dec 22, 2019

It seems that concurrent access is not supported by rediscache.
Current implementation, One client (may be injected to an application) use single connection.
https://godoc.org/github.com/garyburd/redigo/redis#hdr-Concurrency

I switch redis client from gomodule/redigo to go-redis/redis. go-redis supports concurrent Tx pipeline.

@vvakame
Copy link
Member

vvakame commented Dec 2, 2020

@juntaki sorry for very late response...
so, I don't wanna make breaking change.
could you try to support both redis client? (e.g. make rediscache2 package, make rediscache.New2 func, or any other good idea you have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants