chore(volta): Make volta_deactivate.sh more portable #84
+17
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Issues addressed I've been getting an issue locally when running volta via lefthook. Specifically, I'd see an error like this: ``` $ git commit -am Test .git/hooks/post-checkout: 13: /home/topher/miniforge3/envs/memfault/etc/conda/deactivate.d/volta_deactivate.sh: Bad substitution ERROR: Command failed with error exit code 1: ``` I tracked the issue down to non-portable bash-specific handling. ### Summary of changes I _think_ adding the shebang (`#!/bin/bash`) _should_ have been sufficient here to get my local machine working, however this had no impact. I'm not going to spend a ton of time debugging this; I re-wrote it to be more portable and avoid the problematic field. ### Test Plan - [x] I can now run `git commit` without error
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @topher200 and the rest of your teammates on |
topher200
commented
Oct 8, 2024
| @@ -3,7 +3,7 @@ | |||
|
|
|||
| package: | |||
| name: {{ name }} | |||
| version: {{ version }}.memfault2 | |||
There was a problem hiding this comment.
I'm keeping open a thread here until I run the GHA and push the new builds to Conda
noahp
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues addressed
I've been getting an issue locally when running volta via lefthook.
Specifically, I'd see an error like this:
I tracked the issue down to non-portable bash-specific handling.
Summary of changes
I think adding the shebang (
#!/bin/bash) should have beensufficient here to get my local machine working, however this had no
impact.
I'm not going to spend a ton of time debugging this; I re-wrote it to be
more portable and avoid the problematic field.
Test Plan
git commitwithout error