Expand cross compilation #124

Noarkhh · 2024-02-23T15:39:19Z

closes membraneframework/membrane_core#721

Up until now there were two public functions that gave information about platform, Bundlex.get_target/0 and Bundlex.platform/0. Their difference was that get_target/0 gave more specific infomation, but later on, when adding crosscompilation support, only platform/0 detected the crosscompilation.

This PR changes behavior of Bundlex.get_target/0, so that when crosscompiling the target map will have it's fields set by environment variables used by Nerves.

This PR also allows for crosscompilation outside of Nerves. The only thing nerves does is set env variables to correct flags and paths, which can be also done by the user that wants to use their custom toolchain.

…lator

lib/bundlex.ex

mat-hek · 2024-02-23T15:47:57Z

lib/bundlex.ex

@@ -47,7 +81,7 @@ defmodule Bundlex do
  @doc """
  Returns family of the platform obtained with `platform/0`.
  """
-  @spec family() :: :unix | :windows
+  @spec family() :: :unix | :windows | :custom


Since we deprecate this function anyway, maybe let's keep it unchanged for better compatibility?

we deprecate platform, not family

mat-hek · 2024-02-23T15:49:11Z

README.md

@@ -172,6 +174,20 @@ As in the case of NIFs, CNodes compiled with Bundlex can be used like any other
 Similarly to CNodes Bundlex provides `Bundlex.Port` module for a little easier interacting with Ports.
 Please refer to the module's documentation to see how to use it.

+### Cross-compilation
+
+With proper setup Bundlex can support cross-compilation. When using Nerves the it should work out of the box. 


Suggested change

With proper setup Bundlex can support cross-compilation. When using Nerves the it should work out of the box.

With proper setup, Bundlex can support cross-compilation. When using Nerves it should work out of the box.

mat-hek · 2024-02-23T15:50:25Z

README.md

+
+With proper setup Bundlex can support cross-compilation. When using Nerves the it should work out of the box. 
+
+Not relying in Nerves and using your own toolchain is also possible, although it wasn't tested. In this scenario the following environment variables need to be set, since they're not handled by Nerves:


Suggested change

Not relying in Nerves and using your own toolchain is also possible, although it wasn't tested. In this scenario the following environment variables need to be set, since they're not handled by Nerves:

Not relying on Nerves and using your own toolchain is also possible, although it wasn't tested. In this scenario, the following environment variables need to be set:

mat-hek · 2024-02-23T15:50:57Z

lib/bundlex.ex

+          %{
+            architecture: String.t() | :unknown,
+            vendor: String.t() | :unknown,
+            os: String.t() | :unknown,
+            abi: String.t() | :unknown


I'd either use nil or "unknown"

lib/mix/tasks/compile.bundlex.ex

mat-hek · 2024-02-27T15:29:37Z

lib/bundlex/platform.ex

+            :nerves
+
+          :error ->
+            Output.warn(


Suggested change

Output.warn(

Output.info(

lib/bundlex.ex

Co-authored-by: Mateusz Front <[email protected]>

FelonEkonom · 2024-02-29T16:23:58Z

.circleci/config.yml

 orbs:
-  elixir: membraneframework/elixir@1
+  elixir: membraneframework/elixir@dev:94bbc77eef4293223822a2f7f31b136ac0833b1f


I'm experimenting with using non-membrane images where they're not required membraneframework/membrane_core#701

Remember to fix it before merging

README.md

lib/bundlex.ex

lib/bundlex/platform.ex

FelonEkonom · 2024-02-29T16:33:33Z

lib/bundlex/toolchain/common/unix/os_deps.ex

@@ -147,7 +147,7 @@ defmodule Bundlex.Toolchain.Common.Unix.OSDeps do

    # TODO: pass the platform via arguments
    # $ORIGIN must be escaped so that it's not treated as an ENV variable
-    rpath_root = if Bundlex.platform() == :macosx, do: "@loader_path", else: "\\$ORIGIN"
+    rpath_root = if Platform.get_target!() == :macosx, do: "@loader_path", else: "\\$ORIGIN"


What is the difference between Platform.get_target!() and Bundlex.get_target!()?

Now deprecated Bundlex.get_platform/0 invoked Platform.get_target!/0, it gives a bit different information than Bundlex.get_target/0, we probably want to get rid of it eventually and rely just on the Bundlex.get_target/0

So why won't you use Bundlex.get_target/0 instead of Platform.get_target!/0?

FelonEkonom

Let me know, when it will be ready for review

mat-hek · 2024-03-05T08:56:11Z

.circleci/config.yml

 orbs:
-  elixir: membraneframework/elixir@1
+  elixir: membraneframework/elixir@dev:527ac9efd5554630ed90dbe24cd35b45dedcca9a


seems like a temporary value

Jakub Pryc and others added 5 commits February 20, 2024 12:57

Expand get_target to include crosscompilation

f98f2a0

WIP

69a4642

Rename Custom toolchain file

d5e2a50

Deprecate Bundlex.platform/0, improve target detection for crosscompi…

8bb966d

…lator

Improve readme

0cd6625

Noarkhh requested a review from FelonEkonom as a code owner February 23, 2024 15:39

Noarkhh requested a review from mat-hek February 23, 2024 15:39

Improve readme

de375e6

mat-hek requested changes Feb 23, 2024

View reviewed changes

Apply reviewers suggestion

9139cf3

Noarkhh requested a review from mat-hek February 26, 2024 12:38

Expand readme

03fdf70

mat-hek reviewed Feb 27, 2024

View reviewed changes

Noarkhh and others added 2 commits February 28, 2024 15:19

Update lib/bundlex.ex

e5403c7

Co-authored-by: Mateusz Front <[email protected]>

Make dialyzer ignore Bundlex.platform/0

3a66c99

Noarkhh requested a review from mat-hek February 28, 2024 14:42

Noarkhh added 2 commits February 29, 2024 16:35

Update orb

c70ee1e

Update orb

120367c

FelonEkonom requested changes Feb 29, 2024

View reviewed changes

Noarkhh added 4 commits February 29, 2024 17:46

Update orb

4b17561

Update orb

bd5e822

Update orb

9f3a369

Apply reviewers suggestion

f545ebd

Noarkhh requested a review from FelonEkonom February 29, 2024 17:17

Noarkhh force-pushed the expand-cross-compilation branch 6 times, most recently from 07c6eb3 to c73d0ec Compare March 4, 2024 14:14

Noarkhh force-pushed the expand-cross-compilation branch 2 times, most recently from d02d01e to 2194cb8 Compare March 4, 2024 14:56

FelonEkonom reviewed Mar 4, 2024

View reviewed changes

Noarkhh force-pushed the expand-cross-compilation branch 2 times, most recently from 3cb3c68 to 70281f4 Compare March 4, 2024 16:41

mat-hek approved these changes Mar 5, 2024

View reviewed changes

Update orb

32971f4

Noarkhh force-pushed the expand-cross-compilation branch from 70281f4 to 32971f4 Compare March 5, 2024 13:15

Noarkhh added 3 commits March 5, 2024 14:34

Stop using Platform to get rpath_root

1c329dc

Use released orb

f22c30c

Satisfy credo

22d0efb

mat-hek requested a review from FelonEkonom March 14, 2024 15:17

FelonEkonom approved these changes Mar 14, 2024

View reviewed changes

Noarkhh force-pushed the expand-cross-compilation branch 2 times, most recently from 30c17f8 to ac0d94a Compare March 18, 2024 13:21

Test new orb

153e777

Noarkhh force-pushed the expand-cross-compilation branch from ac0d94a to 153e777 Compare March 18, 2024 13:22

Use released orb

c191919

Noarkhh merged commit a03b048 into master Mar 18, 2024
3 checks passed

Noarkhh deleted the expand-cross-compilation branch March 18, 2024 13:58

Noarkhh mentioned this pull request Mar 18, 2024

Bump bundlex dependency to 1.4, fix for cross-compile on OSX. membraneframework/membrane_portaudio_plugin#51

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Expand cross compilation #124

Expand cross compilation #124

Noarkhh commented Feb 23, 2024

mat-hek Feb 23, 2024

Noarkhh Feb 23, 2024

mat-hek Feb 23, 2024

mat-hek Feb 23, 2024

mat-hek Feb 23, 2024

mat-hek Feb 27, 2024

FelonEkonom Feb 29, 2024 •

edited

Loading

Noarkhh Feb 29, 2024

FelonEkonom Mar 4, 2024

FelonEkonom Feb 29, 2024

Noarkhh Feb 29, 2024

FelonEkonom Mar 4, 2024

FelonEkonom left a comment •

edited

Loading

mat-hek Mar 5, 2024

	With proper setup Bundlex can support cross-compilation. When using Nerves the it should work out of the box.
	With proper setup, Bundlex can support cross-compilation. When using Nerves it should work out of the box.


		With proper setup Bundlex can support cross-compilation. When using Nerves the it should work out of the box.

		Not relying in Nerves and using your own toolchain is also possible, although it wasn't tested. In this scenario the following environment variables need to be set, since they're not handled by Nerves:

	Not relying in Nerves and using your own toolchain is also possible, although it wasn't tested. In this scenario the following environment variables need to be set, since they're not handled by Nerves:
	Not relying on Nerves and using your own toolchain is also possible, although it wasn't tested. In this scenario, the following environment variables need to be set:

Expand cross compilation #124

Expand cross compilation #124

Conversation

Noarkhh commented Feb 23, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

FelonEkonom Feb 29, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

FelonEkonom left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

FelonEkonom Feb 29, 2024 •

edited

Loading

FelonEkonom left a comment •

edited

Loading