Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix precompiled in mix releases #120

Merged
merged 6 commits into from
Jan 4, 2024
Merged

Fix precompiled in mix releases #120

merged 6 commits into from
Jan 4, 2024

Conversation

mat-hek
Copy link
Member

@mat-hek mat-hek commented Dec 21, 2023

Closes membraneframework/membrane_core#674

Todo:

  • put precompiled deps into bundlex's priv dir
  • fix rpath on Mac OS
  • fix rpath on linux
  • make symlinks relative
  • add tests

@mat-hek mat-hek changed the base branch from master to fix-mix-target December 21, 2023 11:51
@mat-hek mat-hek marked this pull request as draft December 22, 2023 17:48
Base automatically changed from fix-mix-target to master January 2, 2024 14:08
@mat-hek mat-hek force-pushed the fix-release-precompiled branch 2 times, most recently from b2bd12f to b57a857 Compare January 3, 2024 09:34
@mat-hek mat-hek marked this pull request as ready for review January 3, 2024 09:36
@mat-hek mat-hek requested a review from Noarkhh January 3, 2024 09:37
@mat-hek mat-hek changed the title Fix release precompiled Fix precompiled in mix releases Jan 3, 2024
@mat-hek mat-hek self-assigned this Jan 3, 2024
lib/bundlex/platform.ex Outdated Show resolved Hide resolved
@mat-hek mat-hek merged commit 2760201 into master Jan 4, 2024
3 checks passed
@mat-hek mat-hek deleted the fix-release-precompiled branch January 4, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mix release doesn't copy precompiled deps into build directory
3 participants