-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typescript migration of client/actions and some more components #785
base: master
Are you sure you want to change the base?
Conversation
|
||
const mapDispatchToProps = (dispatch: Dispatch) => ({ | ||
actions: bindActionCreators({getLabelOptions}, dispatch), | ||
}) as unknown as Actions; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this correct to use unknown
here?
isClearable={true} | ||
placeholder={'Select...'} | ||
noOptionsMessage={() => noOptionsMessage} | ||
closeMenuOnSelect={!this.props.isMulti} | ||
hideSelectedOptions={this.props.isMulti} | ||
onChange={this.onChange} | ||
onChange={this.onChange as any} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to add a proper type here and on line 134 ?
This PR has been automatically labelled "stale" because it hasn't had recent activity. |
Summary
Ticket Link