Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework "second main phase" abilities #12970

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Rework "second main phase" abilities #12970

wants to merge 9 commits into from

Conversation

theelk801
Copy link
Contributor

Still need to write tests and root out corner cases

closes #12788

@github-actions github-actions bot added the tests label Oct 15, 2024
@theelk801 theelk801 marked this pull request as ready for review October 15, 2024 22:17
@theelk801
Copy link
Contributor Author

I think this is ready to go

JayDi85
JayDi85 approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@JayDi85 JayDi85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don’t forget about additional checks in #12788 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JayDi85 JayDi85 JayDi85 approved these changes

@xenohedron xenohedron xenohedron approved these changes

Assignees
No one assigned
Labels
cards engine tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor needed for "second main phase"
3 participants
@theelk801 @JayDi85 @xenohedron