Ikoria Cardruns #12762
Draft
Ikoria Cardruns #12762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not full collation implementation, just the cardruns so that collation implementation will be easy to complete.
|
Not tracking down the failure - just leaving the information here for anyone that wishes to complete it. |
Now that I understand collation generation better, I was able to complete this code. I am still expecting it to fail because mutate creatures have been omitted from beta (but are included in collation) Because I have a preference for Japanese Collation over US, I included commented out code for Japanese collation as an alternative. For simplicity, I have used the base prints for rares and mythics only. So that is one further possible improvement.
|
Even though this passed Travis, I am guessing it should not be merged into beta because of mutate creatures. But it should be at a point where it could be merged into alpha. |
|
Full stats avaliable at https://vm1.substation33.com/tiera/t/lethe/ (click on the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not full collation implementation, just the cardruns so that collation implementation will be easy to complete