Remove superfluous items which were moved to the calibre mod #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
do not merge prior to linuxserver/docker-mods#774 being merged |
|
I am a bot, here are the test results for this PR:
|
thespad
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
while working on some issues in lazylibrarian with missing packages, it was determined that the missing packages are required for the calibre mod. In the case of CW, these were being installed on the container which did not appear to need them without the calibre mod. a paired PR (linuxserver/docker-mods#774) adds these packages into the mod so that it works consistently across both LL and CW.
Benefits of this PR and context:
Remove the packages which aren't needed for the base install. speeds up install and reduces size.
How Has This Been Tested?
tested locally for base functionality without mod, added mod PR to confirm functionality